Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make code block styling in LaTeXWriter consistent with HTML #1956

Merged
merged 4 commits into from
Sep 30, 2022
Merged

Make code block styling in LaTeXWriter consistent with HTML #1956

merged 4 commits into from
Sep 30, 2022

Conversation

odow
Copy link
Collaborator

@odow odow commented Sep 29, 2022 •
edited
Loading

Closes #1944

Now

```
A code block
```

```@example
1 + 1
```

produces

image

The raw code blocks have a gray background {minted} with text as the language, and text/plain outputs are left as {lstlisting}s.

I also pulled in the margins of the {lstlisting} because they were slightly wider than the {minted} environments.

@odow
Copy link
Collaborator Author

odow commented Sep 29, 2022

This isn't quite right, because ````markdown blocks are white:

image

in HTML they are

image

@mortenpi mortenpi added Type: Enhancement Format: LaTeX Related to the LaTeX / PDF output labels Sep 29, 2022
mortenpi
mortenpi approved these changes Sep 30, 2022
View reviewed changes
Copy link
Member

@mortenpi mortenpi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great. It's good to go from your end?

@odow
Copy link
Collaborator Author

odow commented Sep 30, 2022

It's good to go from your end?

Yes, I think so.

@mortenpi mortenpi merged commit 5662f71 into JuliaDocs:master Sep 30, 2022
@odow odow mentioned this pull request Sep 30, 2022
Merged
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mortenpi mortenpi mortenpi approved these changes

Assignees
No one assigned
Labels
Format: LaTeX Related to the LaTeX / PDF output Type: Enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Make code block styling in LaTeX consistent with HTML
2 participants
@odow @mortenpi