-
-
Notifications
You must be signed in to change notification settings - Fork 393
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[docs] build with Documenter#master (v0.28-DEV) #3094
Conversation
Codecov ReportBase: 97.68% // Head: 97.68% // No change to project coverage 👍
Additional details and impacted files@@ Coverage Diff @@
## master #3094 +/- ##
=======================================
Coverage 97.68% 97.68%
=======================================
Files 33 33
Lines 4442 4442
=======================================
Hits 4339 4339
Misses 103 103 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
Things are a lot better (compare against https://jump.dev/JuMP.jl/dev/JuMP.pdf). Here are some thoughts of things we could still change: We're missing the logoThe warning color looks gold, rather than yellowis not the same as I don't really like the fontParticularly these bullets and you can't tell |
Success! We can see the full table. cc @mortenpi Here's a failure though:
|
@mortenpi muuuch better |
Closing. This can wait for the documenter release. |
I would suggest using |
Are more breaking changes expected? I guess the two breaking changes are pretty minor: https://github.com/JuliaDocs/Documenter.jl/blob/master/CHANGELOG.md#version-v0280-unreleased |
I would like to get this one fixed, but it may lead to some slightly breaking behavior. Just been a little short on time right now. |
The two main arguments for switching are:
These two changes are quite nice, and I try to stay abreast of the changes in Documenter, so I think I'm willing to live dangerously until the next release. |
I would suggest committing a |
Perhaps I'll just use a specific commit for now. |
Preview link: https://jump.dev/JuMP.jl/previews/PR3094/JuMP.pdf
I've been working on a bunch of changes that will land in Documenter@0.28. They're currently unreleased, so here's a WIP PR to see them in practice.