Allow scalar iteration in the REPL on 1.9+. #450
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks to JuliaLang/julia#48400, we can now detect the REPL task and tweak how scalar indexing is treated. Specifically, I think we should allow scalar iteration in the REPL's frontend task, which is only going to be used to render objects (a common source of scalar iteration). Current GPUArrays already tried to do this by checking
isinteractive()
, but since that may be a false positive, we were still warning about scalar iteration.Old behavior, with JLArrays' output functions disabled (and
show
hence triggering scalar iteration):New behavior:
Fixes #446