-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
JOSS Paper #135
JOSS Paper #135
Conversation
Codecov Report
@@ Coverage Diff @@
## master #135 +/- ##
==========================================
- Coverage 92.32% 92.23% -0.10%
==========================================
Files 11 10 -1
Lines 1447 1442 -5
==========================================
- Hits 1336 1330 -6
- Misses 111 112 +1
Continue to review full report at Codecov.
|
a few examples to show what content and length to expect: |
Thanks! Happy to contribute. Should we use something like overleaf before pushing it back into the repo? |
Nice! JOSS requires a simple markdown and renders the PDF for us, so we can stay with that, if you agree, but we can look for a collaborative editing tool for markdown, I guess that's a good idea anyways. |
For the last JOSS paper we used hackmd.io but I have no premium account and it seems they limited some features since then |
Ah didn’t know that. Markdown is pretty wysiwyg so we can always use a shared google doc :) |
Alright, I invited you to a shared Google doc, I guess that should do it Edit: JOSS requires the paper to sit in the repository, so we can sync it back when we are done with the first draft. This is the preview service: https://whedon.theoj.org I added a GitHub action for the PDF preview. |
(we probably wanna disable CI, not sure how) Putting up a list of things to cite (at least mention & compare)
|
CI fails because the table drawing characters don't exist for the font. When I tried https://whedon.theoj.org/, it just stripped out those characters entirely but still compiled: EDIT: CI works but |
Damn tables 😆 maybe we find a working example out there... |
Codecov Report
@@ Coverage Diff @@
## master #135 +/- ##
=======================================
Coverage 90.14% 90.14%
=======================================
Files 11 11
Lines 1604 1604
=======================================
Hits 1446 1446
Misses 158 158 Continue to review full report at Codecov.
|
is this ready to go? |
@Moelf and @aminnj can you have a look? I think it's more or less ready to go. There are probably still a few typos though 😅 Just edit as you like and if once everyone here agrees, I'll go ahead and submit it. (@Moelf I combined the changes and additions in your last commit and then also rebased and force pushed.) |
OK, Jerry approved, if @aminnj is fine with it, I'll go ahead with the review request 🙂 |
* Add skeleton * Add open journal PDF generator GHA * Fix path to source file * Set output path * summary and statement of need * Minor cosmetics * Add comparison intro and uproot * Add uproot reference * add functionality * add performance citation * small additions * for ci * Cite pandas and numpy * Add ROOT citation * Cleanup and some additions * Minor updates and additions * Update references * Cleanup and additions * Update conclusions with Jerry's comments * Fix typo * Add NanoAOD refernce * Add reference to CMS/NanoAOD * Fix pandas reference * Add spaces between words and references * Fix typo Co-authored-by: Jerry Ling <proton@jling.dev> Co-authored-by: Nick Amin <amin.nj@gmail.com>
* Add skeleton * Add open journal PDF generator GHA * Fix path to source file * Set output path * summary and statement of need * Minor cosmetics * Add comparison intro and uproot * Add uproot reference * add functionality * add performance citation * small additions * for ci * Cite pandas and numpy * Add ROOT citation * Cleanup and some additions * Minor updates and additions * Update references * Cleanup and additions * Update conclusions with Jerry's comments * Fix typo * Add NanoAOD refernce * Add reference to CMS/NanoAOD * Fix pandas reference * Add spaces between words and references * Fix typo Co-authored-by: Jerry Ling <proton@jling.dev> Co-authored-by: Nick Amin <amin.nj@gmail.com>
* Add skeleton * Add open journal PDF generator GHA * Fix path to source file * Set output path * summary and statement of need * Minor cosmetics * Add comparison intro and uproot * Add uproot reference * add functionality * add performance citation * small additions * for ci * Cite pandas and numpy * Add ROOT citation * Cleanup and some additions * Minor updates and additions * Update references * Cleanup and additions * Update conclusions with Jerry's comments * Fix typo * Add NanoAOD refernce * Add reference to CMS/NanoAOD * Fix pandas reference * Add spaces between words and references * Fix typo Co-authored-by: Jerry Ling <proton@jling.dev> Co-authored-by: Nick Amin <amin.nj@gmail.com>
@Moelf and @aminnj I'd like to invite you to collaborate on a short (a few pages) JOSS paper, so that we get a DOI which is citable. The purpose of this publication is to introduce
UnROOT
to the world, outline the reason of its existence, show some short usage examples and compare it with existing other solution. No more, no less;)
Let me know if you are interested. I already added both of you to the template since we three are now definitely the main devs and the core team!
Feel free to dump ideas and add your affiliations (and @aminnj add your ORCID) if you're in.