Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Get IntervalArithmetic.jl ready for Julia 1.0 #194

Merged
merged 29 commits into from
Sep 3, 2018
Merged

Get IntervalArithmetic.jl ready for Julia 1.0 #194

merged 29 commits into from
Sep 3, 2018

Conversation

dpsanders
Copy link
Member

@dpsanders dpsanders commented Aug 17, 2018

(Incorporates the previous PRs for 0.7.)

@dpsanders
Copy link
Member Author

Sorry, should have rebased instead of merging.

@dpsanders
Copy link
Member Author

I suggest that we don't squash when we merge this.

@coveralls
Copy link

coveralls commented Aug 17, 2018

Coverage Status

Coverage increased (+4.4%) to 97.104% when pulling c0e96cf on dps/0.7 into a9d3ef0 on master.

@codecov-io
Copy link

codecov-io commented Aug 17, 2018

Codecov Report

Merging #194 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #194   +/-   ##
=======================================
  Coverage   92.67%   92.67%           
=======================================
  Files          24       24           
  Lines        1120     1120           
=======================================
  Hits         1038     1038           
  Misses         82       82

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a9d3ef0...c0e96cf. Read the comment docs.

@dpsanders
Copy link
Member Author

Tests are passing! ;) Still a bit of work to do though.

@lbenet
Copy link
Member

lbenet commented Aug 17, 2018

Note that deprecation warnings in CRlibm were solved; it is a question of tagging a new version.

@lbenet
Copy link
Member

lbenet commented Aug 17, 2018

Nice work!

@dpsanders dpsanders mentioned this pull request Aug 17, 2018
10 tasks
@lbenet
Copy link
Member

lbenet commented Aug 17, 2018

I just checked that, except for a single test, all tests in test/interval_tests/complex.jl pass. The problematic one is @test a^2 == -1. I suggest to have the tests for complex numbers, and either comment the problematic case or use @test_broken for it.

@lbenet
Copy link
Member

lbenet commented Aug 17, 2018

@mohamed82008 Have you check that tests pass in windows for this branch (dps/0.7)?
If I recall some of the discussion, in spite of appveyor opinion, tests were failing in windows.

@mohamed82008
Copy link

Not yet. I will as soon as I'm infront of a computer.

@dpsanders
Copy link
Member Author

@lbenet Great, let's do that then. Would you like to do it or shall I?

@mohamed82008
Copy link

Tests pass on my machine. I am only getting the setrounding warning.

@dpsanders
Copy link
Member Author

The latest commit needs the next tagged version of CRlibm (in progress) and of SetRounding (to come).

@dpsanders
Copy link
Member Author

All tests are passing on 0.7, 1.0 and nightly, on all platforms!
This is ready to merge. cc @lbenet

@dpsanders dpsanders changed the title WIP: Remove deprecation warnings on 0.7 Get IntervalArithmetic.jl ready for Julia 1.0 Aug 19, 2018
@lbenet
Copy link
Member

lbenet commented Aug 19, 2018

Thanks a lot for the big effort!

I think we should first tag a last version which is compatible with Julia 0.6 of ValidatedNumerics.jl and the rest of the packages with the proper version, and then merge and tag this PR. See JuliaIntervals/ValidatedNumerics.jl#285, whose tests should be working now.

@dpsanders
Copy link
Member Author

There are no changes on master since v0.14.0, so we can treat v0.14.0 as the last version compatible with Julia 0.6.

@dpsanders
Copy link
Member Author

Upper bounds for the other packages can be added retroactively directly in METADATA, without tagging new versions of them.

@lbenet
Copy link
Member

lbenet commented Aug 22, 2018

Shall we merge this and tag a new version (Julia 0.7 and 1.0 compatible only)?

@dpsanders
Copy link
Member Author

Merging...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants