Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to Julia 0.7 #52

Merged
merged 22 commits into from
Sep 6, 2018
Merged

Update to Julia 0.7 #52

merged 22 commits into from
Sep 6, 2018

Conversation

lbenet
Copy link
Collaborator

@lbenet lbenet commented Aug 21, 2018

No description provided.

@lbenet lbenet changed the title Require Julia 0.7 and update minimum version of dependencies Update to Julia 0.7 Aug 21, 2018
@lbenet lbenet mentioned this pull request Aug 21, 2018
@coveralls
Copy link

coveralls commented Aug 21, 2018

Coverage Status

Coverage increased (+1.4%) to 100.0% when pulling ada5e72 on lb/julia0.7 into 1567bba on master.

@codecov
Copy link

codecov bot commented Aug 21, 2018

Codecov Report

Merging #52 into master will increase coverage by 1.36%.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff            @@
##           master    #52      +/-   ##
========================================
+ Coverage   98.63%   100%   +1.36%     
========================================
  Files           5      5              
  Lines         438    234     -204     
========================================
- Hits          432    234     -198     
+ Misses          6      0       -6
Impacted Files Coverage Δ
src/TaylorIntegration.jl 100% <100%> (ø) ⬆️
src/rootfinding.jl 100% <100%> (ø) ⬆️
src/common.jl 100% <100%> (+18.75%) ⬆️
src/explicitode.jl 100% <100%> (ø) ⬆️
src/liapunovspectrum.jl 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1567bba...ada5e72. Read the comment docs.

@lbenet
Copy link
Collaborator Author

lbenet commented Aug 21, 2018

I had to comment some tests involving Taylor1{Taylor1{T}} in test/rootfinding.jl; the problem is related to some ambiguity in the promotion rules that has to be solved in TaylorSeries..jl. So I think this is essentially ready.

@lbenet
Copy link
Collaborator Author

lbenet commented Aug 23, 2018

Tests do not pass because the last version of TaylorSeries (compatible with Julia0.7) needs to be tagged.

@PerezHz
Copy link
Owner

PerezHz commented Aug 24, 2018

Many thanks for this, @lbenet! Can confirm that locally tests pass with julia 0.7.0 and TaylorSeries current master... So we should wait for a new TaylorSeries tag before merging this, right?

@lbenet
Copy link
Collaborator Author

lbenet commented Aug 24, 2018

We may have to be a bit patient: TaylorSeries.jl is waiting for IntervalArithmetics.jl get a tagged version working on Julia 0.7; that version is ready (JuliaIntervals/IntervalArithmetic.jl#194 (comment)), but there seems to be some issues in METADATA (see JuliaLang/METADATA.jl#17216).

cc @dpsanders

@lbenet lbenet mentioned this pull request Sep 5, 2018
@lbenet
Copy link
Collaborator Author

lbenet commented Sep 6, 2018

Tests pass locally; they require v0.8.0 of TaylorSeries.jl

@lbenet
Copy link
Collaborator Author

lbenet commented Sep 6, 2018

Tests pass :-)

@PerezHz
Copy link
Owner

PerezHz commented Sep 6, 2018

Since TaylorIntegration v0.3.1 has been tagged (see #54). I went ahead and rebased to current master. Tests pass locally, as well as in travis and appveyor. I propose that once JuliaLang/METADATA.jl#17778 is merged, we should tag v0.4.0, the first TaylorIntegration release fully compatible with julia 0.7/1.0. Many thanks for all the effort you put to bring TaylorIntegration to julia 0.7 and 1.0 @lbenet!

@PerezHz
Copy link
Owner

PerezHz commented Sep 6, 2018

Update: JuliaLang/METADATA.jl#17778 has been merged

@lbenet
Copy link
Collaborator Author

lbenet commented Sep 6, 2018

Did you rebase to current master? Auch!!

@lbenet
Copy link
Collaborator Author

lbenet commented Sep 6, 2018

Tests pass. Merging.

@lbenet lbenet merged commit d77fe2b into master Sep 6, 2018
@lbenet lbenet deleted the lb/julia0.7 branch September 7, 2018 15:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants