-
-
Notifications
You must be signed in to change notification settings - Fork 117
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
range(start, stop)
without kwargs accidentally allowed
#640
Comments
27 tasks
martinholters
added a commit
that referenced
this issue
Jan 18, 2019
martinholters
added a commit
that referenced
this issue
Jan 22, 2019
martinholters
added a commit
that referenced
this issue
Jan 22, 2019
martinholters
added a commit
that referenced
this issue
Jan 22, 2019
So the plan is to
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Compat.jl/src/Compat.jl
Lines 1853 to 1855 in ce5d74b
So before
1.1.0-DEV.506
,range(start, stop)
will becomerange(start, stop=stop)
, which works, using a default step of 1. On1.1.0-DEV.506
or later, the Base definition ofrange(start, stop)
errors, requiringstep
orlength
to be specified. Unfortunately, ONNX.jl already makes use of therange(start, stop)
form, making it at preset incompatible with the upcoming julia-1.1.0 (ref. JuliaLang/julia#30374 (comment)).Not sure what to do here. In the long run, we should make
range(start, stop)
error on 1.0, too, but that would be a breaking change. (Altough, we nowhere claim it to work, so one might argue it's really a bugfix). In the short term... Should we override the Base method to allowrange(start, stop)
? That feels so ... wrong.The text was updated successfully, but these errors were encountered: