Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

srand is now Random.seed! #601

Merged
merged 4 commits into from
Jan 22, 2019
Merged

srand is now Random.seed! #601

merged 4 commits into from
Jan 22, 2019

Conversation

rdeits
Copy link
Contributor

@rdeits rdeits commented Aug 4, 2018 •
edited
Loading

@rdeits
Copy link
Contributor Author

rdeits commented Aug 4, 2018

Ah, this doesn't work because the Compat.Random module only ends up containing the exported symbols from Base.Random. I can either:

  1. Import every symbol from Base.Random into Compat.Random individually
  2. Instead of creating a separate Compat.Random module, just do @eval Random const seed! = srand

Any opinions?

@stevengj
Copy link
Member

stevengj commented Aug 4, 2018

Let's just manually import symbols that are documented but not exported.

@rdeits
Copy link
Contributor Author

rdeits commented Aug 8, 2018

Ok, this is a bit closer now. The only things I know I'm missing are the new randperm! and randcycle! functions.

@fredrikekre fredrikekre mentioned this pull request Aug 15, 2018
Closed
galenlynch added a commit to galenlynch/Formatting.jl that referenced this pull request Aug 15, 2018
@galenlynch
Fix use of Random.seed!
66385a8 
Compat does not yet support Random.seed! See
[#601](JuliaLang/Compat.jl#601).
galenlynch added a commit to galenlynch/Formatting.jl that referenced this pull request Aug 17, 2018
@galenlynch
Use Random.seed! for testing (Julia 1.0 compatibility)
4903214 
srand has been deprecated in favor of Random.seed!

Compat does not yet support Random.seed! See
[#601](JuliaLang/Compat.jl#601).
@rdeits
Copy link
Contributor Author

rdeits commented Aug 25, 2018

Bump?

@AsafManela
Copy link

bump

@traktofon
Copy link
Contributor

Bump? Or is it considered obsolete by now?

@martinholters
Copy link
Member

Sorry for having neglected this. I'll merge if CI comes out green.

@martinholters martinholters merged commit 633ccb3 into JuliaLang:master Jan 22, 2019
@rdeits rdeits deleted the rd/random-seed branch January 22, 2019 13:57
@martinholters martinholters mentioned this pull request Jan 22, 2019
Closed
@martinholters
Copy link
Member

martinholters commented Jan 28, 2019 •
edited
Loading

This broke (at least) StatsBase because it doens't provide RangeGenerator and GLOBAL_RNG in Random. Fix incoming. (EDIT: #647)

@martinholters martinholters mentioned this pull request Jan 28, 2019
Merged
martinholters added a commit that referenced this pull request Oct 4, 2019
@martinholters
Mark Compat.Random from #460, #601, and #647 for deprecation
989e85c
martinholters added a commit that referenced this pull request Oct 8, 2019
@martinholters
Mark Compat.Random from #460, #601, and #647 for deprecation
f1c2a3f
martinholters added a commit that referenced this pull request Oct 13, 2019
@martinholters
Drop support for Julia versions <1.0 (#665)
4fa5519 
* Bump required Julia version to 1.0

* Remove compatibility support code for:
  * `at-__MODULE__` (from #363)
  * `devnull`, `stdin`, `stdout`, and `stderr` from #499
  * `at-nospecialize` (from #385 and #409)
  * `isabstracttype` and `isconcretetype` (from #477)
  * `invokelatest` from #424
  * array-like access to `Cmd` from #379
  * `Val(n)` and `ntuple`/`reshape` with `Val` from #381 and #399
  * `logdet(::Any)` fallback from #382
  * `chol(::UniformScaling)` from #382
  * `pushfirst!`, `popfirst!` from #444
  * `fieldcount` from #386
  * `read(obj, ::Type{String})` from #385 and #580
  * `InexactError`, `DomainError`, and `OverflowError` constructors from #393
  * `corrected` kw arg to `cov` from #401
  * `adjoint` from #401
  * `partialsort` from #401
  * `pairs` from #428
  * `AbstractRange` from #400
  * `rtoldefault` from #401
  * `Dates.Period` rounding from #462
  * `IterativeEigensolvers` from #435
  * `occursin` from #520
  * `Char` concatenation from #406
  * `BitSet` from #407
  * `diagm` and `spdiagm` with pairs from #408
  * `Array` c'tors from `UniformScaling` from #412 and #438
  * `IOContext` ctor taking pairs from #427
  * `undef` from #417 and #514
  * `get` on `ENV` from #430
  * `ComplexF...` from #431
  * `tr` from #614
  * `textwidth` from #644
  * `isnumeric` from #543
  * `AbstractDict` from #435
  * `axes` #435 and #442
  * `Nothing` and `Cvoid` from #435
  * `Compat.SuiteSparse` from #435
  * `invpermute!` from #445
  * `replace` with a pair from #445
  * `copyto!` from #448
  * `contains` from #452
  * `CartesianIndices` and `LinearIndices` from #446, #455, and #524
  * `findall` from #466 (and #467).
  * `argmin` and `argmax` from #470, #472, and #622
  * `parentmodule` from #461
  * `codeunits` from #474
  * `nameof` from #471
  * `GC` from #477
  * `AbstractDisplay` from #482
  * `bytesavailable` from #483
  * `firstindex` and `lastindex` from #480 and #494
  * `printstyled` from #481
  * `hasmethod` from #486
  * `objectid` from #486
  * `Compat.find*` from #484 and #513
  * `repr` and `showable` from #497
  * `Compat.names` from #493 and #505
  * `Compat.round` and friends #500, #530, and #537
  * `IOBuffer` from #501 and #504
  * `range` with kw args and `LinRange` from #511
  * `cp` and `mv` from #512
  * `indexin` from #515
  * `isuppercase` and friends from #516
  * `dims` and `init` kwargs from #518, #528, #590, #592, and #613
  * `selectdim` from #522 and #531
  * `repeat` from #625
  * `fetch(::Task)` from #549
  * `isletter` from #542
  * `isbitstype` from #560
  * `at-cfunction` from #553 and #566
  * `codeunit` and `thisind` and friends from #573
  * `something` from #562
  * `permutedims` from #582
  * `atan` from #574
  * `split` and `rsplit` from #572
  * `mapslices` from #588
  * `floatmin` and `floatmax` from #607
  * `dropdims` from #618
  * required keyword arguments from #586
  * `CartesianRange` in `at-compat` from #377
  * `finalizer` from #416
  * `readline`, `eachline`, and `readuntil` from #477, #541, and #575
  * curried `isequal`, `==`, and `in` from #517
  * `Some` from #435 and #563
  * `at-warn` and friends from #458

* Remove old deprecations

* Deprecate:
  * `Compat.Sockets` from #545 and #594
  * `TypeUtils` from #304
  * `macros_have_sourceloc` from #355
  * `Compat.Sys` from #380, #433, and #552
  * `Compat.MathConstants` from #401
  * `Compat.Test`, `Compat.SharedArrays`, `Compat.Mmap`, and `Compat.DelimitedFiles` from #404
  * `Compat.Dates` from #413
  * `Compat.Libdl` from #465 (and #467)
  * `AbstractDateTime` from #443
  * `Compat.Printf` from #435
  * `Compat.LinearAlgebra` from #463
  * `Compat.SparseArrays` from #459
  * `Compat.Random` from #460, #601, and #647
  * `Compat.Markdown` from #492
  * `Compat.REPL` from #469
  * `Compat.Serialization` from #473
  * `Compat.Statistics` from #583
  * `Fix2` from #517
  * `Compat.Base64` from #418
  * `Compat.Unicode` from #432 and #507
  * `notnothing` from #435 and #563
  * `Compat.IteratorSize` and `Compat.IteratorEltype` from #451
  * `enable_debug(::Bool)` from #458
  * `Compat.Distributed` from #477
  * `Compat.Pkg` from #485
  * `Compat.InteractiveUtils` from #485
  * `Compat.LibGit2` from #487
  * `Compat.UUIDs` from #490
  * `Compat.qr` from #534
  * `Compat.rmul!` from #546
  * `Compat.norm` abd friends from #577

* Remove obsolete README entry, missed in #385

* Remove obsolete tests (e.g. missed in #372)

* Remove obsolete `VERSION` conditionals and some minor clean-up
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stevengj stevengj stevengj approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@rdeits @stevengj @AsafManela @traktofon @martinholters