Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Compat.at-error, Compat.at-warn, Compat.at-info and Compat.at-debug #458

Merged
merged 1 commit into from
Jan 18, 2018
Merged

Add Compat.at-error, Compat.at-warn, Compat.at-info and Compat.at-debug #458

merged 1 commit into from
Jan 18, 2018

Conversation

fredrikekre
Copy link
Member

replacement for #453 which I managed to mess up....

@fredrikekre fredrikekre mentioned this pull request Jan 16, 2018
Closed
@fredrikekre fredrikekre force-pushed the fe/logging branch 4 times, most recently from 736a717 to be081de Compare January 17, 2018 06:40
ararslan
ararslan approved these changes Jan 17, 2018
View reviewed changes
Copy link
Member

@ararslan ararslan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good as far as I can tell. Thanks! It might be worth mentioning MicroLogging or something in the README given the caveat about the 0.6/0.7 difference.

@fredrikekre fredrikekre force-pushed the fe/logging branch 2 times, most recently from 2096a93 to ea7ae26 Compare January 17, 2018 07:06
@fredrikekre
Copy link
Member Author

Added a reference to MicroLogging.

c42f
c42f approved these changes Jan 17, 2018
View reviewed changes
Copy link
Member

@c42f c42f left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Given these aren't exported I think this is a nice addition. Thanks for making it.

My only real comment is that having debug visible by default might be hopelessly verbose.

src/Compat.jl
@@ -1229,6 +1229,50 @@ end
end
end

@static if !isdefined(Base, Symbol("@info"))
macro info(msg, args...)
return :(info($(esc(msg)), prefix = "Info: "))
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you want 0.6 equivalent formatting, perhaps skip the prefix for @info and @warn?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I did it like this to be consistent with 0.7, and also to differentiate logging errors from actual errors, which prints ERROR: in all caps red.

src/Compat.jl Outdated
@static if !isdefined(Base, Symbol("@error"))
function _error(msg)
buf = IOBuffer()
iob = Base.redirect(IOContext(buf, STDERR), Base.log_info_to, :error)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Use Base.log_error_to, perhaps?

README.md Outdated
- The loglevel can not be controlled
- Extra metadata sent to the macros are ignored

As an alternative, see the MicroLogging.jl package for a logging interface similar to the one in Julia 0.7.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is accurate. While I plan to update MicroLogging, it's not possible to provide exact equivalence in a package.

src/Compat.jl
return
end
macro debug(msg, args...)
return :(debug($(esc(msg))))
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Debug messages are invisible by default in 0.7, so I think having them visible here by default might end up being hopelessly verbose.

Maybe a simplistic global flag which disables debug by default might be a good idea?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good idea, we can have const DEBUG = Ref(false) in Compat, such that people can turn it on.

@fredrikekre fredrikekre merged commit 0b398b8 into master Jan 18, 2018
@fredrikekre fredrikekre deleted the fe/logging branch January 18, 2018 14:23
@fredrikekre fredrikekre mentioned this pull request Apr 24, 2018
Closed
martinholters added a commit that referenced this pull request Oct 8, 2019
@martinholters
Drop compat code for at-warn and friends from #458
e65b355 
And mark `enable_debug(::Bool)` for deprecation.
martinholters added a commit that referenced this pull request Oct 8, 2019
@martinholters
Drop compat code for at-warn and friends from #458
c74ee3a 
And mark `enable_debug(::Bool)` for deprecation.
martinholters added a commit that referenced this pull request Oct 8, 2019
@martinholters
Drop compat code for at-warn and friends from #458
833a0b0 
And mark `enable_debug(::Bool)` for deprecation.
martinholters added a commit that referenced this pull request Oct 13, 2019
@martinholters
Drop support for Julia versions <1.0 (#665)
4fa5519 
* Bump required Julia version to 1.0

* Remove compatibility support code for:
  * `at-__MODULE__` (from #363)
  * `devnull`, `stdin`, `stdout`, and `stderr` from #499
  * `at-nospecialize` (from #385 and #409)
  * `isabstracttype` and `isconcretetype` (from #477)
  * `invokelatest` from #424
  * array-like access to `Cmd` from #379
  * `Val(n)` and `ntuple`/`reshape` with `Val` from #381 and #399
  * `logdet(::Any)` fallback from #382
  * `chol(::UniformScaling)` from #382
  * `pushfirst!`, `popfirst!` from #444
  * `fieldcount` from #386
  * `read(obj, ::Type{String})` from #385 and #580
  * `InexactError`, `DomainError`, and `OverflowError` constructors from #393
  * `corrected` kw arg to `cov` from #401
  * `adjoint` from #401
  * `partialsort` from #401
  * `pairs` from #428
  * `AbstractRange` from #400
  * `rtoldefault` from #401
  * `Dates.Period` rounding from #462
  * `IterativeEigensolvers` from #435
  * `occursin` from #520
  * `Char` concatenation from #406
  * `BitSet` from #407
  * `diagm` and `spdiagm` with pairs from #408
  * `Array` c'tors from `UniformScaling` from #412 and #438
  * `IOContext` ctor taking pairs from #427
  * `undef` from #417 and #514
  * `get` on `ENV` from #430
  * `ComplexF...` from #431
  * `tr` from #614
  * `textwidth` from #644
  * `isnumeric` from #543
  * `AbstractDict` from #435
  * `axes` #435 and #442
  * `Nothing` and `Cvoid` from #435
  * `Compat.SuiteSparse` from #435
  * `invpermute!` from #445
  * `replace` with a pair from #445
  * `copyto!` from #448
  * `contains` from #452
  * `CartesianIndices` and `LinearIndices` from #446, #455, and #524
  * `findall` from #466 (and #467).
  * `argmin` and `argmax` from #470, #472, and #622
  * `parentmodule` from #461
  * `codeunits` from #474
  * `nameof` from #471
  * `GC` from #477
  * `AbstractDisplay` from #482
  * `bytesavailable` from #483
  * `firstindex` and `lastindex` from #480 and #494
  * `printstyled` from #481
  * `hasmethod` from #486
  * `objectid` from #486
  * `Compat.find*` from #484 and #513
  * `repr` and `showable` from #497
  * `Compat.names` from #493 and #505
  * `Compat.round` and friends #500, #530, and #537
  * `IOBuffer` from #501 and #504
  * `range` with kw args and `LinRange` from #511
  * `cp` and `mv` from #512
  * `indexin` from #515
  * `isuppercase` and friends from #516
  * `dims` and `init` kwargs from #518, #528, #590, #592, and #613
  * `selectdim` from #522 and #531
  * `repeat` from #625
  * `fetch(::Task)` from #549
  * `isletter` from #542
  * `isbitstype` from #560
  * `at-cfunction` from #553 and #566
  * `codeunit` and `thisind` and friends from #573
  * `something` from #562
  * `permutedims` from #582
  * `atan` from #574
  * `split` and `rsplit` from #572
  * `mapslices` from #588
  * `floatmin` and `floatmax` from #607
  * `dropdims` from #618
  * required keyword arguments from #586
  * `CartesianRange` in `at-compat` from #377
  * `finalizer` from #416
  * `readline`, `eachline`, and `readuntil` from #477, #541, and #575
  * curried `isequal`, `==`, and `in` from #517
  * `Some` from #435 and #563
  * `at-warn` and friends from #458

* Remove old deprecations

* Deprecate:
  * `Compat.Sockets` from #545 and #594
  * `TypeUtils` from #304
  * `macros_have_sourceloc` from #355
  * `Compat.Sys` from #380, #433, and #552
  * `Compat.MathConstants` from #401
  * `Compat.Test`, `Compat.SharedArrays`, `Compat.Mmap`, and `Compat.DelimitedFiles` from #404
  * `Compat.Dates` from #413
  * `Compat.Libdl` from #465 (and #467)
  * `AbstractDateTime` from #443
  * `Compat.Printf` from #435
  * `Compat.LinearAlgebra` from #463
  * `Compat.SparseArrays` from #459
  * `Compat.Random` from #460, #601, and #647
  * `Compat.Markdown` from #492
  * `Compat.REPL` from #469
  * `Compat.Serialization` from #473
  * `Compat.Statistics` from #583
  * `Fix2` from #517
  * `Compat.Base64` from #418
  * `Compat.Unicode` from #432 and #507
  * `notnothing` from #435 and #563
  * `Compat.IteratorSize` and `Compat.IteratorEltype` from #451
  * `enable_debug(::Bool)` from #458
  * `Compat.Distributed` from #477
  * `Compat.Pkg` from #485
  * `Compat.InteractiveUtils` from #485
  * `Compat.LibGit2` from #487
  * `Compat.UUIDs` from #490
  * `Compat.qr` from #534
  * `Compat.rmul!` from #546
  * `Compat.norm` abd friends from #577

* Remove obsolete README entry, missed in #385

* Remove obsolete tests (e.g. missed in #372)

* Remove obsolete `VERSION` conditionals and some minor clean-up
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ararslan ararslan ararslan approved these changes

@c42f c42f c42f approved these changes

@KristofferC KristofferC Awaiting requested review from KristofferC

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@fredrikekre @c42f @ararslan