Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

un-export FastMath functions sin_fast etcetera #18460

Closed
stevengj opened this issue Sep 12, 2016 · 1 comment
Closed

un-export FastMath functions sin_fast etcetera #18460

stevengj opened this issue Sep 12, 2016 · 1 comment
Labels
maths Mathematical functions

Comments

@stevengj
Copy link
Member

#17302 accidentally exported deprecations for sin_fast(array) etcetera, when these should in fact be in module Base.FastMath. (As a result, the deprecated "vector" methods are exported but the scalar methods are not.)

cc: @Sacha0
@ararslan
Copy link
Member

This came up in other submodules as well. See for example #18456.

Sacha0 added a commit to Sacha0/julia that referenced this issue Sep 12, 2016
@Sacha0
Deprecate vectorized FastMath functions in FastMath module rather tha…
f16597a 
…n Base. Fixes JuliaLang#18460.
@Sacha0 Sacha0 mentioned this issue Sep 12, 2016
Merged
@kshyatt kshyatt added the maths Mathematical functions label Sep 13, 2016
kshyatt added a commit that referenced this issue Sep 13, 2016
@kshyatt
Merge pull request #18463 from Sacha0/unexportfm
47ec910 
Fix #18460 (deprecate vectorized FastMath functions in Base.FastMath, not Base)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
maths Mathematical functions
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@kshyatt @stevengj @ararslan