Deprecate @vectorize_1arg for Dates functions within scope of Dates module
#18456
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Otherwise there are issues with functions being independently defined within multiple modules: ```julia julia> using Base.Dates julia> unix2datetime(0) WARNING: both Dates and Base export "unix2datetime"; uses of it in module Main must be qualified ERROR: UndefVarError: unix2datetime not defined ```
| :unix2datetime, :rata2datetime, :julian2datetime, # base/dates/conversions.jl | ||
| ) | ||
| eval(Dates, :(Base.@dep_vectorize_1arg Real $f)) | ||
| end |
There was a problem hiding this comment.
IMHO those parentheses make it kind of hard to read. Might be nicer as
# base/dates/*.jl
for f in (:unix2datetime, :rata2datetime, :julian2datetime) # base/dates/conversions.jl
eval(Dates, :(Base.@dep_vectorize_1arg Real $f))
endThere was a problem hiding this comment.
Will change. Was just matching the surrounding style.
|
Thanks for catching and fixing this @omus! |
kshyatt
added
dates
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Deprecations for
@vectorize_1argintroduced in #17302 causes Date module functions to be created in Base. I noticed this issue when running: