Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

relocatedepot tests are flaky. #53103

Closed
gbaraldi opened this issue Jan 29, 2024 · 2 comments · Fixed by #53110
Closed

relocatedepot tests are flaky. #53103

gbaraldi opened this issue Jan 29, 2024 · 2 comments · Fixed by #53110
Labels
ci Continuous integration

Comments

@gbaraldi
Copy link
Member

The relocatedepot tests fail sometimes, it doesn't seem to be specific to a platform since it happens in macos https://buildkite.com/julialang/julia-master/builds/32827#018d545b-d100-456d-9457-abdffcb752be/778-1617 and in windows https://buildkite.com/julialang/julia-master/builds/32787#018d5202-e985-42d8-b62f-e76ddcb7ad52/26541-26929
@gbaraldi gbaraldi mentioned this issue Jan 29, 2024
Closed
@giordano giordano added the ci Continuous integration label Jan 29, 2024
@giordano
Copy link
Contributor

For reference and ease of search, the error message is something like

Error in testset relocatedepot:
Error During Test at /Users/julia/.julia/scratchspaces/a66863c6-20e8-4ff4-8a62-49f30b1f605e/agent-cache/default-macmini-x64-6.0/build/default-macmini-x64-6-0/julialang/julia-master/julia-9669eecc99/share/julia/test/relocatedepot.jl:98
  Got exception outside of a @test
  SystemError: opening file "/private/var/tmp/agent-tempdirs/default-macmini-x64-6.0/tmp/jl_dhqcV3/compiled/v1.11/Foo.ji": No such file or directory

@staticfloat
Copy link
Member

#ci-dev discussed this and thinks it's highly likely that the issue is that a previously-loaded Foo package is interfering with Base.require() and we should instead use Base.compilecache() to force compilation. (Also perhaps avoid using the Foo name, and embed an issue number into the name to disambiguate.)

@giordano giordano mentioned this issue Jan 29, 2024
Merged
giordano added a commit that referenced this issue Jan 30, 2024
@giordano
Make relocatedepot test more robust (#53110)
75c38e3 
As discussed in the `#ci-dev` call (see
#53103 (comment)
and
#53104 (comment))
there were two problems:

* the use of `Base.require` caused the package to be loaded
* the name of the package was a generic placeholder, and clashed with
other packages loaded during the tests called with the same generic
name.

The solution was to rename test module with a more specific name, and
replace `Base.require` with `Base.compilecache`, the latter only
compiles the package without loading it.

Should fix #53103, close #53104.
@fatteneder fatteneder mentioned this issue Feb 2, 2024
Merged
@fatteneder fatteneder mentioned this issue Feb 11, 2024
Merged
Keno pushed a commit that referenced this issue Feb 11, 2024
@fatteneder
Tests: rename Foo test pkg (#53289)
86c0191 
Encountered another instance of a flaky `Foo.jl` test pkg which caused
me trouble locally.

Xref:
#53103 (comment)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
ci Continuous integration
Projects
None yet
Milestone
No milestone
3 participants
@staticfloat @giordano @gbaraldi