Add track_content option to allow hashing of include_dependencys
#51798
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Need to add a Julia compat note to docs. |
DilumAluthge
added
needs compat annotation
fatteneder
commented
Oct 28, 2023
fatteneder
force-pushed
the
fa/incl-deps-track-content
branch
from
c35908f to
01d0b4d
Compare
fatteneder
removed
the
needs compat annotation
fatteneder
force-pushed
the
fa/incl-deps-track-content
branch
from
01d0b4d to
54421ed
Compare
fatteneder
force-pushed
the
fa/incl-deps-track-content
branch
from
174f65a to
e7c171e
Compare
fatteneder
commented
Dec 12, 2023
stevengj
reviewed
Dec 27, 2023
fatteneder
force-pushed
the
fa/incl-deps-track-content
branch
from
05813f5 to
eb3b131
Compare
This was referenced Jan 3, 2024
fatteneder
force-pushed
the
fa/incl-deps-track-content
branch
from
eb3b131 to
606c535
Compare
fatteneder
added
the
awaiting review
staticfloat
approved these changes
Feb 1, 2024
fatteneder
force-pushed
the
fa/incl-deps-track-content
branch
from
606c535 to
0554073
Compare
|
After rebasing there is now a test failure that seems related to #53103. |
vchuravy
reviewed
Feb 2, 2024
vchuravy
reviewed
Feb 2, 2024
IanButterworth
removed
the
awaiting review
Co-authored-by: Valentin Churavy <vchuravy@users.noreply.github.com>
This was referenced May 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Continuation of #49866.
Fixes #52462
So far any
include_dependencywas tracked bymtime.A package using
include_dependencycan't be relocated without recompilation if the dependency also needs to be relocated.With
include_dependency(path, track_content=true)the tracking works like forinclude,i.e. recompilation is only triggered when the file's content changes.
In case
pathis a directory we use the stringjoin(readdir(path))as content.