Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release-0.4] pending backports for final RC #13357

Merged
merged 44 commits into from
Oct 3, 2015
Merged

Conversation

tkelman
Copy link
Contributor

@tkelman tkelman commented Sep 29, 2015

hopefully final, anyway

vtjnash and others added 18 commits September 27, 2015 17:25
(cherry picked from commit 780d9af)

Conflicts:
	base/deprecated.jl
* Make `jl_linenode_line` non-allocating
* Fix missing GC root when calling `jl_fieldref` and `jl_get_nth_field`
  that can possibly allocate
* Add missing write barrier when using heap allocated array as stack buffer
* Remove a few allocation from `jl_static_show_x` (the general case still
  allocate and should be fixed)
* Fix missing and extra `JL_GC_POP`
* Fix misplaced `JL_GC_PUSH*`

(backported from 34c9332)
ref #13325
(cherry picked from commit 6dd817f)
ref #13328
(cherry picked from commit 2fb0433)
Combines the `doc(::Function)` and `doc(::DataType)` methods since they
were nearly identical.

Enables searching for docstrings attached to specific constructors in the
same manner as is currently allowed for normal methods. Prior to this it
resulted in a no method error.

Fixes #12701 where splatted method docs were shadowing others. Although not
the original cause of the issue, with the change to storing signatures
as `Tuple{...}` (in #12835) this meant that `f(x...)` was stored as
`Tuple{Vararg{Any}}` which is equal to `Tuple`. Since the default value of
`sig` was `Tuple` not all matching docs were returned in the example
provided in #12701.

(cherry picked from commit 1b1e6c6)
ref #13330
Enable `apropos` search via help mode by passing a string or regex:

    help?> "foo"
    help?> r"foo"

This shouldn't interfere with any docstring lookup since we don't encourage
documenting specific strings or regex objects. Docs for `@r_str` can still
be found by searching for either an empty regex `r""` or `@r_str` directly.

Enable specifying method signatures using

    help?> f(::Float64, ::Int)

as well as the current behaviour

    help?> f(x, y)

where `x` and `y` are already defined. This is quite useful when you don't
have an instance of the required type. Prior to this an error was thrown
in `gen_call_with_extracted_types` when using the `::` syntax.

(cherry picked from commit 8c236e9)
(cherry picked from commit bc43fe6)
ref #13341
(cherry picked from commit 8624221)
ref #13335
ReStructured is very finicky about this – bullets, etc. must be
fully flush left relative to their parent block or Sphinx wraps them
in a literal quote block. This commit also fixes a few other broken
RST syntax usages.

(cherry picked from commit 84204a8)
and adjust rst rendering so genstdlib is consistent

(cherry picked from commit f8d05e0)

Adjust test/markdown.jl for list spacing

whoops, shame on me

(cherry picked from commit 17328be)
@tkelman tkelman added this to the 0.4.0 milestone Sep 29, 2015
tkelman and others added 8 commits September 29, 2015 00:07
I resolved that conflict wrong, the deprecate_binding exports the old name
and AsyncStream was not exported
(cherry picked from commit 0715058)
ref #13115
This adds a `@__doc__` macro, not exported currently, for use by macro authors
that want their macros to hook into the docsystem properly.

Usage:

    macro example(f)
        quote
            $(f)() = 0
            @__doc__ $(f)(x) = 1
            $(f)(x, y) = 2
        end |> esc
    end

    "Docs for `g(x)` only."
    @example g

will attach the docstring to the 1-arg method only.

Also improve invalid doc expression error message by displaying the
unexpanded form of the expression instead of its expansion.

Enable docstrings for `at-enum` using the newly added macro.

Fixes #12705.

(cherry picked from commit 0b9ef7d)
ref #13006
(cherry picked from commit 449c6da)
ref #13354

removed tests for methods that have not been backported to release-0.4
(cherry picked from commit 2eb5a50)
…nly doc string to julia.

(cherry picked from commit 2305d49)
ref #13370
These were broken by #11274 but no one noticed. Fixes #13350.

(cherry picked from commit 7dfcf70)
ref #13355
@tkelman
Copy link
Contributor Author

tkelman commented Sep 30, 2015

--- 035d559015/summary  2015-09-27 23:00:04.286518673 -0400
+++ fef1fb825c/summary  2015-09-30 10:05:56.065284571 -0400
@@ -6,6 +6,8 @@
 "tests_fail"
 nightly/AmplNLWriter.json
 "tests_fail"
+nightly/AndorSIF.json
+"tests_fail"
 nightly/AnsiColor.json
 "tests_pass"
 nightly/AppConf.json
@@ -73,7 +75,7 @@
 nightly/Blink.json
 "tests_pass"
 nightly/Blocks.json
-"tests_pass"
+"tests_fail"
 nightly/BloomFilters.json
 "tests_fail"
 nightly/Blosc.json
@@ -228,6 +230,8 @@
 "not_possible"
 nightly/CUFFT.json
 "not_possible"
+nightly/CURAND.json
+"tests_fail"
 nightly/Curl.json
 "no_tests"
 nightly/CurveFit.json
@@ -363,7 +367,7 @@
 nightly/Faker.json
 "tests_pass"
 nightly/FastaIO.json
-"tests_fail"
+"tests_pass"
 nightly/FastAnonymous.json
 "tests_pass"
 nightly/FastArrayOps.json
@@ -372,6 +376,8 @@
 "tests_pass"
 nightly/FileFind.json
 "no_tests"
+nightly/FileIO.json
+"tests_pass"
 nightly/FinancialMarkets.json
 "tests_fail"
 nightly/FiniteStateMachine.json
@@ -409,7 +415,7 @@
 nightly/FunctionalUtils.json
 "no_tests"
 nightly/Gadfly.json
-"tests_pass"
+"tests_fail"
 nightly/GARCH.json
 "tests_fail"
 nightly/Gaston.json
@@ -550,11 +556,15 @@
 "not_possible"
 nightly/IJuliaPortrayals.json
 "tests_pass"
+nightly/ImageMagick.json
+"tests_pass"
 nightly/ImageQuilting.json
 "tests_pass"
 nightly/Images.json
 "tests_pass"
 nightly/ImageView.json
+"tests_pass"
+nightly/ImagineFormat.json
 "tests_fail"
 nightly/Immerse.json
 "tests_fail"
@@ -821,7 +831,7 @@
 nightly/MFCC.json
 "tests_pass"
 nightly/MIDI.json
-"tests_fail"
+"tests_pass"
 nightly/Millboard.json
 "tests_pass"
 nightly/MinimalPerfectHashes.json
@@ -875,7 +885,7 @@
 nightly/MutableStrings.json
 "no_tests"
 nightly/Mux.json
-"tests_pass"
+"tests_fail"
 nightly/NaiveBayes.json
 "tests_pass"
 nightly/NamedArrays.json
@@ -894,6 +904,8 @@
 "not_possible"
 nightly/NetCDF.json
 "tests_fail"
+nightly/Netpbm.json
+"tests_pass"
 nightly/Nettle.json
 "tests_pass"
 nightly/NeuralynxNCS.json
@@ -911,13 +923,15 @@
 nightly/NLreg.json
 "tests_fail"
 nightly/NLsolve.json
-"tests_pass"
+"tests_fail"
 nightly/NMEA.json
 "tests_pass"
 nightly/NMF.json
 "no_tests"
 nightly/NPZ.json
 "no_tests"
+nightly/NRRD.json
+"tests_fail"
 nightly/NullableArrays.json
 "tests_pass"
 nightly/NumericExtensions.json
@@ -1056,6 +1070,8 @@
 "tests_pass"
 nightly/QuantEcon.json
 "tests_fail"
+nightly/QuartzImageIO.json
+"tests_fail"
 nightly/Quaternions.json
 "tests_pass"
 nightly/QuickCheck.json
@@ -1148,8 +1164,6 @@
 "tests_fail"
 nightly/SemidefiniteProgramming.json
 "not_possible"
-nightly/SerialLib.json
-"no_tests"
 nightly/SerialPorts.json
 "tests_pass"
 nightly/SFML.json
@@ -1223,7 +1237,7 @@
 nightly/SpecialMatrices.json
 "tests_pass"
 nightly/SPTK.json
-"tests_fail"
+"tests_pass"
 nightly/SQLite.json
 "tests_fail"
 nightly/StackedNets.json
@@ -1317,7 +1331,7 @@
 nightly/TimeZones.json
 "tests_pass"
 nightly/Tk.json
-"tests_fail"
+"tests_pass"
 nightly/TOML.json
 "tests_pass"
 nightly/TopicModels.json
@@ -1385,11 +1399,11 @@
 nightly/Weave.json
 "tests_fail"
 nightly/WebSockets.json
-"tests_pass"
+"tests_fail"
 nightly/WinRPM.json
 "no_tests"
 nightly/Winston.json
-"tests_fail"
+"tests_pass"
 nightly/WoodburyMatrices.json
 "tests_pass"
 nightly/WordNet.json
@@ -1419,7 +1433,7 @@
 nightly/ZChop.json
 "tests_pass"
 nightly/ZipFile.json
-"tests_pass"
+"tests_fail"
 nightly/Zlib.json
 "tests_pass"
 nightly/ZMQ.json

https://gist.github.com/aae9eec4cd222657f717

Gadfly is a timeout and NLsolve's tests fail half the time, Blocks looks like a real issue though: MethodError: eof has no method matching eof(::Base.FS.File)

Mux and WebSockets failed due to UndefVarError: UVServer not defined in HttpServer. HttpServer itself was failing before, but due to an MbedTLS certificate problem.

ZipFile was: ERROR: LoadError: test error in expression: ascii(read(dir.files[1],@compat(UInt8),length(s1))) == s1 MethodError: convert has no method matching convert(::Type{ASCIIString}, ::Void)

So fixing #12975 with the IO refactoring from #12839 would come at the cost of breaking several packages.

@tanmaykm
Copy link
Member

tanmaykm commented Oct 1, 2015

@tkelman JuliaParallel/Blocks.jl#17 should fix Blocks

MichaelHatherly and others added 5 commits October 1, 2015 17:56
Types with fields containing unicode characters would throw an error
since the initial type of the `parts` vector would be ASCII instead of
utf8.

(cherry picked from commit 5947f3c)
ref #13386
…eed to rename the library to avoid conflicts

(cherry picked from commit b0bc951)
ref #13407
@JeffBezanson
Copy link
Member

d09545b should also be backported.

@tkelman
Copy link
Contributor Author

tkelman commented Oct 2, 2015

Still getting the buildbots back up after a failure. In the meantime, @fhs is not responding very actively about there's this issue with ZipFile, that package is used by 4 or 5 others. Would be a little unfortunate to break the package right before a release. Though it's also broken on nightlies for similar reasons, if anyone wants to help look into it.

tkelman and others added 3 commits October 2, 2015 21:10
Fix MethodError from giving too many inputs to PkgError

Add an unsatisfiable REQUIRES test

Add tests for Pkg.pin error cases

Adjust comment for issue number in a test

(cherry picked from commit 9d368d4)
ref #13420
and add corresponding tests

(cherry picked from commit 3a57ccb)
To avoid breakage when getindex is overwritten

(cherry picked from commit d09545b)
ref #13260
@tkelman
Copy link
Contributor Author

tkelman commented Oct 3, 2015

We're in pretty good shape. https://gist.github.com/anonymous/2d48b86e683caaf5bb0b

GeoIP passes locally so I think it was a corrupted zip download. NLsolve is same convergence thing. TimeSeries is a new failure but I think it's a package precompilation issue since there were a bunch of tags of related packages recently, and the same problem happens using rc3. cc @milktrader on that

Merging, will tag rc4 today if nothing urgent comes up.

tkelman added a commit that referenced this pull request Oct 3, 2015
[release-0.4] pending backports for final RC
@tkelman tkelman merged commit cde997c into release-0.4 Oct 3, 2015
@tkelman tkelman deleted the tk/backports5 branch October 3, 2015 16:43
@milktrader
Copy link
Contributor

Is there a test log that I can inspect with TimeSeries? Tests are passing locally, but on rc1. There are some deprecation warnings here in the latest Travis test

@tkelman
Copy link
Contributor Author

tkelman commented Oct 4, 2015

check TimeSeries.json in the gist I linked to above. Messy to read raw, I recommend using JSON.jl to pretty print it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.