-
-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Document that the REPL workflow assumes your module is in LOAD_PATH #24223
Conversation
Thanks @rdeits You might want to include |
I originally wrote that, but I wasn't sure if that was the best thing to recommend in the manual. If a user does In Julia v0.7, |
Although I guess this change will only affect the v0.7 manual, right? So then perhaps the most correct thing would be to change the example to: push!(LOAD_PATH, @__DIR__) |
Btw I thing the error message |
I totally agree. Would you like me to come up with a better wording for it in this PR, or should we save that for the next one? |
I don't mind. I think I would replace |
How about "LOAD_PATH or Pkg.dir()", since it could be in either location? |
Yes that's perfect! Thank you! |
Ok, I've made the change to "LOAD_PATH or Pkg.dir()" |
Hm, it looks like having julia> push!(LOAD_PATH, @__DIR__)
3-element Array{Any,1}:
"/Applications/Julia-0.6.app/Contents/Resources/julia/local/share/julia/site/v0.6"
"/Applications/Julia-0.6.app/Contents/Resources/julia/share/julia/site/v0.6"
nothing
julia> using StaticArrays
ERROR: ArgumentError: unrecognized custom loader in LOAD_PATH: nothing
Stacktrace:
[1] load_hook(::Void, ::String, ::String) at ./loading.jl:94
[2] find_in_path(::String, ::Void) at ./loading.jl:116
[3] find_in_node_path(::String, ::Void, ::Int64) at ./loading.jl:125
[4] _require(::Symbol) at ./loading.jl:426
[5] require(::Symbol) at ./loading.jl:398
julia> versioninfo()
Julia Version 0.6.0
Commit 903644385b (2017-06-19 13:05 UTC)
Platform Info:
OS: macOS (x86_64-apple-darwin13.4.0)
CPU: Intel(R) Core(TM) i7-2860QM CPU @ 2.50GHz
WORD_SIZE: 64
BLAS: libopenblas (USE64BITINT DYNAMIC_ARCH NO_AFFINITY Sandybridge)
LAPACK: libopenblas64_
LIBM: libopenlibm
LLVM: libLLVM-3.9.1 (ORCJIT, sandybridge) but everything is fine on v0.7. Is that still ok, since this is just a change to the 0.7+ manual? |
What is having |
It's not supposed to do anything. This came up because |
This change won't end up in the v0.6 docs anyway, so should be ok. |
Ok, great! |
Is this good to go? |
supplanted by #26804? |
I think the |
On my vanilla OSX setup and Julia 1.0, the Workflow Tips section of the manual does not work as advertised; this PR would help immensely. |
Inspired by https://discourse.julialang.org/t/repl-workflow-reload-doesnt-work/6571 I noticed that the workflow tips section of the manual quietly assumes that the module the user is developing is on the LOAD_PATH. I've added a bullet point to make that requirement explicit.
Please let me know if the wording of this is OK.