load path: change default LOAD_PATH (#25709) #26804

StefanKarpinski · 2018-04-13T23:36:50Z

also:

rename "site" directory to "stdlib" since that's what it is now
use JULIA_LOAD_PATH as-is instead unconditionally appending the
system package and stdlib directories to it
change default DEPOT_PATH to include system paths: one for
arch-specific and one for arch-independent packages
delete comment about bundled code going in a versioned directory
as it no longer applies since installed packages can and should
be shared across different Julia versions

StefanKarpinski · 2018-04-13T23:38:33Z

src/common_symbols2.inc

@@ -127,7 +127,6 @@ jl_symbol("pipe_writer"),
 jl_symbol("idxfloor"),
 jl_symbol("id"),
 jl_symbol("ComplexF32"),
-jl_symbol("/home/jeff/src/julia/usr/share/julia/site/v0.7/Pkg/src/resolve/versionweight.jl"),


I do use this symbol all the time.

The data we have says that you do, in fact, use it all the time :)

vchuravy · 2018-04-14T23:46:41Z

doc/src/manual/environment-variables.md

 `/bin/julia` will have a default `LOAD_PATH` of

 ```
-/local/share/julia/site/v0.6
-/share/julia/site/v0.6
+/local/share/julia/stdlib/v0.7


If I read the code for init_load_path correctly /local/share is no longer used

Ah, good point.

vchuravy · 2018-04-14T23:47:54Z

stdlib/Pkg3/test/utils.jl

@@ -13,8 +13,8 @@ function temp_pkg_dir(fn::Function)
                pushfirst!(DEPOT_PATH, depot_dir)
                # Add the standard library paths back
                vers = "v$(VERSION.major).$(VERSION.minor)"
-                push!(LOAD_PATH, abspath(Sys.BINDIR, "..", "local", "share", "julia", "site", vers))
-                push!(LOAD_PATH, abspath(Sys.BINDIR, "..", "share", "julia", "site", vers))
+                push!(LOAD_PATH, abspath(Sys.BINDIR, "..", "local", "share", "julia", "stdlib", vers))


JeffBezanson · 2018-04-17T19:09:30Z

base/initdefs.jl

    vers = "v$(VERSION.major).$(VERSION.minor)"
-    push!(LOAD_PATH, abspath(BINDIR, "..", "local", "share", "julia", "site", vers))
-    push!(LOAD_PATH, abspath(BINDIR, "..", "share", "julia", "site", vers))
+    stdlib = abspath(BINDIR, "..", "share", "julia", "stdlib", vers)


Is it kosher to have a directory environment nested inside a depot directory? I guess nothing prevents it, but it could maybe lead to confusion.

JeffBezanson · 2018-04-17T19:13:58Z

doc/src/manual/environment-variables.md

@@ -68,23 +68,13 @@ and a global configuration search path of
 ### `JULIA_LOAD_PATH`

 A separated list of absolute paths that are to be appended to the variable
-[`LOAD_PATH`](@ref). (In Unix-like systems, the path separator is `:`; in Windows


This should probably now say "used to set LOAD_PATH" instead of "appended to LOAD_PATH".

JeffBezanson · 2018-04-17T19:14:50Z

doc/src/manual/environment-variables.md

+the absolute path
+`$JULIA_HOME/../share/julia/stdlib/v$(VERSION.major).$(VERSION.minor)` so that,
+e.g., version 0.7 of Julia on a Linux system with a Julia executable at
+`/bin/julia` will have a default `LOAD_PATH` of `/share/julia/stdlib/v0.7`.


This should be moved to the doc string for LOAD_PATH.

All of this really needs to be rewritten for the new code loading. I'm just trying to make the functional changes that are necessary here; the doc updates can be made in a separate pass.

also: - rename "site" directory to "stdlib" since that's what it is now - use JULIA_LOAD_PATH as-is instead unconditionally appending the system package and stdlib directories to it - change default DEPOT_PATH to include system paths: one for arch-specific and one for arch-independent packages - delete comment about bundled code going in a versioned directory as it no longer applies since installed packages can and should be shared across different Julia versions - update Pkg3 and tests to work correctly when the stdlib directory isn't always included in LOAD_PATH fix failing tests

StefanKarpinski · 2018-04-19T00:47:12Z

AppVeyor timed out but got far enough to see that the previously-failing Pkg3 tests are now passing.

* origin/master: (22 commits) separate `isbitstype(::Type)` from `isbits` (#26850) bugfix for regex matches ending with non-ASCII (#26831) [NewOptimizer] track inbounds state as a per-statement flag change default LOAD_PATH and DEPOT_PATH (#26804, fix #25709) Change url scheme to https (#26835) [NewOptimizer] inlining: Refactor todo object inference: enable CodeInfo method_for_inference_limit_heuristics support (#26822) [NewOptimizer] Fix _apply elision (#26821) add test case from issue #26607, cfunction with no args (#26838) add `do` in front-end deparser. fixes #17781 (#26840) Preserve CallInst metadata in LateLowerGCFrame pass. Improve differences from R documentation (#26810) reserve syntax that could be used for computed field types (#18466) (#26816) Add support for Atomic{Bool} (Fix #26542). (#26597) Remove argument restriction on dims2string and inds2string (#26799) (#26817) remove some unnecessary `eltype` methods (#26791) optimize: ensure merge_value_ssa doesn't drop PiNodes inference: improve tmerge for Conditional and Const ensure more iterators stay type-stable code loading docs (#26787) ...

maleadt · 2018-04-23T06:28:20Z

This PR and its docs seem to imply JULIA_LOAD_PATH should append to LOAD_PATH, but it looks like it's completely overriding instead? Testing on de705f3:

$ ./julia -e "display(LOAD_PATH)"
4-element Array{Any,1}:
 Base.CurrentEnv()                                                                                                                     
 Any[Base.NamedEnv("v0.7.0"), Base.NamedEnv("v0.7"), Base.NamedEnv("v0"), Base.NamedEnv("default"), Base.NamedEnv("v0.7", create=true)]
 "/home/tbesard/Julia/julia-dev/build/release/usr/share/julia/stdlib/v0.7"                                                             
 Pkg.dir

$ JULIA_LOAD_PATH=/tmp ./julia -e "display(LOAD_PATH)"
2-element Array{Any,1}:
 "/tmp" 
 Pkg.dir

This breaks, e.g., using Pkg after setting JULIA_LOAD_PATH in order to quickly pick up a package from a custom path. If that is unsupported now, what's an easy alternative?

EDIT: ah, just saw #26804 (comment)

StefanKarpinski requested review from KristofferC, stevengj and JeffBezanson April 13, 2018 23:37

StefanKarpinski added the packages Package management and loading label Apr 13, 2018

StefanKarpinski added this to the 1.0 milestone Apr 13, 2018

StefanKarpinski commented Apr 13, 2018

View reviewed changes

vchuravy reviewed Apr 14, 2018

View reviewed changes

JeffBezanson reviewed Apr 17, 2018

View reviewed changes

StefanKarpinski force-pushed the sk/load_path branch from 10fd8e4 to bb80ea0 Compare April 18, 2018 20:59

StefanKarpinski force-pushed the sk/load_path branch from bb80ea0 to 6d0a780 Compare April 18, 2018 21:01

StefanKarpinski merged commit 50413a4 into master Apr 19, 2018

StefanKarpinski deleted the sk/load_path branch April 19, 2018 00:48

StefanKarpinski mentioned this pull request Apr 26, 2018

Defining JULIA_LOAD_PATH breaks Pkg #26904

Closed

vtjnash mentioned this pull request May 8, 2018

Document that the REPL workflow assumes your module is in LOAD_PATH #24223

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

load path: change default LOAD_PATH (#25709) #26804

load path: change default LOAD_PATH (#25709) #26804

StefanKarpinski commented Apr 13, 2018

StefanKarpinski Apr 13, 2018

JeffBezanson Apr 16, 2018

vchuravy Apr 14, 2018

StefanKarpinski Apr 15, 2018

vchuravy Apr 14, 2018

JeffBezanson Apr 17, 2018

JeffBezanson Apr 17, 2018

JeffBezanson Apr 17, 2018

StefanKarpinski Apr 17, 2018

StefanKarpinski commented Apr 19, 2018

maleadt commented Apr 23, 2018 •

edited

Loading

load path: change default LOAD_PATH (#25709) #26804

load path: change default LOAD_PATH (#25709) #26804

Conversation

StefanKarpinski commented Apr 13, 2018

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

StefanKarpinski commented Apr 19, 2018

maleadt commented Apr 23, 2018 • edited Loading

maleadt commented Apr 23, 2018 •

edited

Loading