The main one left is in concatenation, in a line

    inds[i] = offsets[i] .+ cat_indices(x, i)

If you've already said `using Test`, defining a function named `Test` causes problems.

This is consistent with the deprecation of methods like `[1,2,3] + 1`.

Among other things, this supports returning AbstractRanges for appropriate inputs.

Fixes #21094, fixes #22053

…implementation

and use a slightly more thorough search through nested arguments

within .-fused expressions that contain custom arrays with custom broadcast styles.

Only needed to manually resolve a trivial conflict in NEWS.md; everything else git did automagically.

Conflicts:
	NEWS.md
	base/broadcast.jl
	base/compiler/optimize.jl
	stdlib/SparseArrays/src/higherorderfns.jl

This comes up when `flatten`-ing a broadcasted object within a "fallback"
`copyto!` method: `flatten` wants to construct a new Broadcast object and
copy the instantiated information, but we've already destroyed the `Style`
information when we deferred dispatch to the destination! So this simply permits
instantiating `Broadcasted{Nothing}` objects in the sole signature that gets
called by `flatten`.

with new infrastructure.  Captures many more cases in a very straightforward manner

…ime test for zero preserving

…ions

Things are vastly improved; the majority of allocations still appear to be coming from the repeated construction of the same function.

to make it bootstrap friendly

We effectively do that in any case with broadcast similar, and it remains type-stable

and remove some unneeded code

* origin/master:
  A few more #26670 fixes (#26773)
  Revert "deprecate using the value of `.=`. fixes #25954" (#26754)
  change dim arguments for `diff` and `unique` to keyword args (#26776)
  reorder pmap arguments to allow do-block syntax (#26783)
  correct deprecated parametric method syntax (#26789)
  [NewOptimizer] handle new IR nodes correctly in binary format
  [NewOptimizer] support line number emission from new IR format
  fix #26453, require obviously-concrete lower bound for a var to be diagonal (#26567)
  fix #26743, spurious `return` path in try-finally in tail position (#26753)
  Also lift SelectInst addrspaces

Some of the broadcasting API users still lean on inference -- that can be fixed up later -- but this now no longer hand-feeds them the inferred result of the broadcast.

This has the slight downside that a type-unstable broadcast will not fall back to the simpler `copyto!` method as it must incrementally widen instead. I find this a worthwhile tradeoff.

Also simplify instantiation now that we no longer need to worry about the eltype.

in favor of just overloading `instantiate(::Broadcasted{CustomStyle})`.

…ed CSCs

as a nicer internal API. Also accomodate the loss of a broadcast style due to falling back to a `Broadcasted{Nothing}`.

[ci skip]

* origin/master: (22 commits)
  separate `isbitstype(::Type)` from `isbits` (#26850)
  bugfix for regex matches ending with non-ASCII (#26831)
  [NewOptimizer] track inbounds state as a per-statement flag
  change default LOAD_PATH and DEPOT_PATH (#26804, fix #25709)
  Change url scheme to https (#26835)
  [NewOptimizer] inlining: Refactor todo object
  inference: enable CodeInfo method_for_inference_limit_heuristics support (#26822)
  [NewOptimizer] Fix _apply elision (#26821)
  add test case from issue #26607, cfunction with no args (#26838)
  add `do` in front-end deparser. fixes #17781 (#26840)
  Preserve CallInst metadata in LateLowerGCFrame pass.
  Improve differences from R documentation (#26810)
  reserve syntax that could be used for computed field types (#18466) (#26816)
  Add support for Atomic{Bool} (Fix #26542). (#26597)
  Remove argument restriction on dims2string and inds2string (#26799) (#26817)
  remove some unnecessary `eltype` methods (#26791)
  optimize: ensure merge_value_ssa doesn't drop PiNodes
  inference: improve tmerge for Conditional and Const
  ensure more iterators stay type-stable
  code loading docs (#26787)
  ...

this solves the allocations in perf_op_bcast

The key insight here is that these indexing helpers are an _implementation detail_ of an optimization for a particular argument type within a given broadcast implementation. They are not universal across all Broadcasted wrappers -- which is precisely why some styles had wanted to opt out of them. Now the _broadcast_getindex function is solely responsible for allowing indexing into arguments with broadcasted dimensions properly constrained as appropriate. The `Extruded` type pre-computes the dimensions to constrain, allowing an optimization for types who do not statically know this answer -- by default just all `AbstractArray`s.

This still has a performance regression over master in the reduced example `f(r, x) = r .= x.*x.*x.*x` because it does not currently vectorize on this branch. Not sure why.

We only need to store the outer set of axes; we do not need the axes of any of the nested Broadcasted objects once that is known -- all other accesses defer to individual argument axes.

that constructs the arguments to call the function. Julia actually knows the value statically, but it doesn't follow the type information through that transient tuple.

broadcasting by preprocessing the arguments to potentially wrap them with indexing helpers.

* Slightly clearer recursion through arg lists in not_nested
* Move show(::IO, ::Broadcasted) to a more sensible location and have it print its type fully qualified with the `Style` parameter.

* origin/master: (23 commits)
  fix deprecations of \cdot and \times (#26884)
  Support reshaping custom 0-dimensional arrays (#26870)
  fix some cases of dot syntax lowering (#26878)
  Pkg3: deterministically close the LibGit2 repo in tests (#26883)
  code loading docs: add missing graph edge (#26874)
  add news for #26858 and #26859 [ci skip] (#26869)
  Deprecate using && and || within at-dot expressions (#26792)
  widen `Int8` and `Int16` to `Int` instead of `Int32` (#26859)
  fix #26038, make `isequal` consistent with `hash` for `Ptr` (#26858)
  Deprecate variadic size(A, dim1, dim2, dims...) method (#26862)
  add using Random to example in manual (#26864)
  warn once instead of depwarn since we want to test it
  Revert "reserve syntax that could be used for computed field types (#18466) (#26816)" (#26857)
  Fix compilation on LLVM 6.0
  change promotion behaviour of `cumsum` and `cumsum!` to match `sum`
  [LLVM 6] add patch to diamond if-conversion
  add a precompile command that can be used to precompile all dependencies (#254)
  use registry if no version entry exist in project for developed pacakges
  make Pkg3 work as a drop in for the old CI scripts
  update registries when adding (#253)
  ...

[ci skip]