Avoid reading inactive rowvals when computing the rank of a QRSparse #29925
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andreasnoack
added
linear algebra
fredrikekre
reviewed
Nov 5, 2018
| @@ -342,7 +342,7 @@ end | |||
| _ret_size(F::QRSparse, b::AbstractVector) = (size(F, 2),) | |||
| _ret_size(F::QRSparse, B::AbstractMatrix) = (size(F, 2), size(B, 2)) | |||
|
|
|||
| LinearAlgebra.rank(F::QRSparse) = maximum(F.R.rowval) | |||
| LinearAlgebra.rank(F::QRSparse) = reduce(max, view(F.R.rowval, 1:nnz(F.R)), init = eltype(F.R.rowval)(0)) | |||
There was a problem hiding this comment.
Use SparseArrays.nzvalview instead?
There was a problem hiding this comment.
I'm using the rowvals here, not the nzvals. We could add rowvalview but I think we should wait until there are more use cases.
KristofferC
pushed a commit
that referenced
this pull request
Nov 12, 2018
tkf
pushed a commit
to tkf/julia
that referenced
this pull request
Nov 21, 2018
KristofferC
pushed a commit
that referenced
this pull request
Dec 12, 2018
KristofferC
pushed a commit
that referenced
this pull request
Feb 11, 2019
KristofferC
pushed a commit
that referenced
this pull request
Feb 20, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #29787