Backports for 1.0.3 #30010
Merged
Backports for 1.0.3 #30010
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
(cherry picked from commit 7454dc9)
(cherry picked from commit 06fed56)
…LVM. (cherry picked from commit 98b0264)
(cherry picked from commit d70b797)
The `CodeInfo` block has a field `codelocs` that indexes into an array with full `LineInfoNode` objects. This data model allows de-duplication, and in practice it does (only) `uniq`-style deduplication, i.e. only consecutive equal objects are deduplicated by this scheme. The lambda `compact-ir` generates this structure. This commit fixes a bug where it mixes monotonously increasing the indices (for `codeloc`) with push/pop operations. This is wrong because the latest `LineInfoNode` object is always at the end of the current size of the array; not one position after the current `LineInfoNode`. (cherry picked from commit 98e7497)
(cherry picked from commit 4e75c93)
Instead of transforming the file names, just create a temporary symlink in the source directory that points back to the root of the source directory. As long as symlinks work properly, this should be a portable solution. (cherry picked from commit 498ff15)
(cherry picked from commit 0cd3ade)
(cherry picked from commit 58fea96)
(cherry picked from commit 024bcb7)
Previously some of the work was shifted, leading to awkward extraneous copies and preventing usage of DEPS_GIT=1 mode (the main point of this script). There also seemed to be unexpected failure modes in the current usage where the files in stdlib/Pkg would routinely go missing for me. I don't know the source of those, but I hope that this will fix it (because it makes more of the state immutable). Also noticed some issues with existing scripts (expanding variables at unintended points, not rebuilding on some changes), and fixed those. (cherry picked from commit ef50e25)
- Ignores additional whitespace when reading in credentials. - Warn when encountering unknown attributes. Should allow for more graceful failures in the future if the protocol is extended. (cherry picked from commit 4b270b1)
* `require` takes to arguments * `jl_new_uniontype` does not exist anymore (cherry picked from commit ef496b0)
- ccall :GetClipboardData failed should throw a `GetClipboardData` error (cherry picked from commit 3dd678f)
While we're guaranteed never to look at undefined values, we're not guaranteed that the type information can't change, which in the case of a union generates code to change the layout. As a result, we need to make sure to have the union selectors be valid (the actual data will be junk and no semantic operation will ever look at it, but it shouldn't be ouf of bounds). Ref #29152 (cherry picked from commit ecd7291)
This fixes a problem where Julia does not find and active project when the ~/.julia/environments/v#.# folder exist but does not contain a Project.toml file. (cherry picked from commit 71748da)
(cherry picked from commit a26031e)
(cherry picked from commit d8558ee)
(cherry picked from commit 13049f2)
(cherry picked from commit 6d94a87)
(cherry picked from commit 72fdb29)
(cherry picked from commit d7198bf)
(cherry picked from commit a3599e9)
|
@nanosoldier |
|
Your benchmark job has completed - possible performance regressions were detected. A full report can be found here. cc @ararslan |
|
PkgEval came back clean 🎉 Just want to double check that the regression is noise: If things are ok we should merge this and announce a testing period of a few days. |
|
@nanosoldier |
|
Your benchmark job has completed - no performance regressions were detected. A full report can be found here. cc @ararslan |
fredrikekre
approved these changes
Dec 12, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backported PRs:
startup.jl#30015 - Added note to highlight that some variables can't be set instartup.jlGC.@preserveinteraction #30048, lowering gc_preserve of closure variablesERROR: syntax: invalid named tuple elementmisleading message #30030, assignment expr as named tuple element valuebroadcast_axesinferrable even if axes are of different types #30074 - Makebroadcast_axesinferrable even if axes are of different typesccacheon OSX Travis #30111 - Installccacheon OSX TravisInteractiveUtils#30130 - varinfo() has been moved toInteractiveUtilsclipboard.jl#30209 - fix typo inclipboard.jlusing#30254 - fix REPL: cannot assign variables whose names match a name exported from Base after any tab autocompletion #30234, don't resolve bindings when tab-completingusingisdeprecatedshould not resolve binding #29962 -isdeprecatedshould not resolve bindingNeed manual backport:
Contains multiple commits, manual intervention needed:
Non-merged PRs with backport label: