Add methods to index identityUnitRange/Slice with another IdentityUnitRange #41224
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stevengj
approved these changes
Jun 14, 2021
|
Test failure seems unrelated |
jishnub
force-pushed
the
indexIdentityUnitRange
branch
from
e007ad5
to
1ffdaff
Compare
|
Gentle bump |
|
Merge (after conflict resolution)? |
jishnub
force-pushed
the
indexIdentityUnitRange
branch
from
1ffdaff
to
93b2201
Compare
mkitti
pushed a commit
to mkitti/julia
that referenced
this pull request
Apr 13, 2024
…tRange (JuliaLang#41224) Adding these methods lets `OffsetArrays` define `getindex(::AbstractUnitRange, ::IdentityUnitRange)` without ambiguities. This is in the domain of sanctioned type-piracy, as the result is an offset range in general and cannot be represented correctly using `Base` types. Re: JuliaArrays/OffsetArrays.jl#244 cc: @johnnychen94 Edit: this also fixes an indexing bug in `IdentityUntiRange`: master ```julia julia> r = Base.IdentityUnitRange(-3:3) Base.IdentityUnitRange(-3:3) julia> r[2] 2 julia> r[big(2)] -2 ``` Co-authored-by: jishnub <jishnub@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding these methods lets
OffsetArraysdefinegetindex(::AbstractUnitRange, ::IdentityUnitRange)without ambiguities. This is in the domain of sanctioned type-piracy, as the result is an offset range in general and cannot be represented correctly usingBasetypes.Re: JuliaArrays/OffsetArrays.jl#244
cc: @johnnychen94
Edit: this also fixes an indexing bug in
IdentityUntiRange:master