Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add thread that runs libuv loop continuously #50880

Closed
wants to merge 18 commits into from
Closed

Add thread that runs libuv loop continuously #50880

wants to merge 18 commits into from

Conversation

gbaraldi
Copy link
Member

@gbaraldi gbaraldi commented Aug 10, 2023 •
edited by vchuravy
Loading

This is slightly speculative, but it fixes #50643 which is a start. But it hasn't been tested under heavy contention of the uv lock.
It also currently uses the normal mutex but we probably need to switch to a lock that has some form of fairness (maybe #50878 )

@brenhinkeller brenhinkeller added the multithreading Base.Threads and related functionality label Aug 10, 2023
@vchuravy vchuravy requested review from JeffBezanson and vtjnash and removed request for JeffBezanson August 11, 2023 15:08
vchuravy
vchuravy reviewed Aug 11, 2023
View reviewed changes
src/jl_uv.c Show resolved Hide resolved
vchuravy
vchuravy reviewed Aug 11, 2023
View reviewed changes
src/julia_threads.h Outdated Show resolved Hide resolved
vchuravy
vchuravy reviewed Aug 11, 2023
View reviewed changes
src/partr.c Show resolved Hide resolved
This was referenced Aug 14, 2023
Merged
Draft
@vtjnash
Copy link
Member

vtjnash commented Aug 24, 2023

xref #35552

vchuravy
vchuravy reviewed Aug 30, 2023
View reviewed changes
src/partr.c Outdated Show resolved Hide resolved
cafaxo
cafaxo reviewed Aug 31, 2023
View reviewed changes
base/threadingconstructs.jl Outdated Show resolved Hide resolved
This was referenced Sep 6, 2023
Open
Closed
@vchuravy vchuravy added the io Involving the I/O subsystem: libuv, read, write, etc. label Sep 13, 2023
@gbaraldi gbaraldi changed the title Remove in threaded region and add a thread that runs the UV loop Add thread that runs libuv loop continuously Feb 7, 2024
@vchuravy
Copy link
Member

@gbaraldi maybe we should split some of the bug fixes out?

@algunion
Copy link

@gbaraldi,

I see this has been stale for some time.

Is this just a matter of evaluating the PR?

Is there additional work that I can help with?

P. S. I am somehow invested in this. Reason #50643.

@vtjnash
Copy link
Member

vtjnash commented Jul 24, 2024

This functionality is already merged (#53422 / 7f92880), though there was possibly comments here about bugfixes that Gabriel wanted to split out?

@maleadt maleadt mentioned this pull request Aug 19, 2024
Open
@danielwe
Copy link
Contributor

This (presumably) fixes #43952, since #50643 was close as a duplicate of it

@vtjnash vtjnash closed this Oct 17, 2024
@vtjnash
Copy link
Member

vtjnash commented Oct 17, 2024

Already merged this, but just waiting to see if Gabriel had any bugfixes here he wanted to land

@oscardssmith
Copy link
Member

don't we still need to turn this on by default?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cafaxo cafaxo cafaxo left review comments

@vchuravy vchuravy vchuravy left review comments

@vtjnash vtjnash Awaiting requested review from vtjnash

@JeffBezanson JeffBezanson Awaiting requested review from JeffBezanson

Assignees
No one assigned
Labels
io Involving the I/O subsystem: libuv, read, write, etc. multithreading Base.Threads and related functionality
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Unexpected sleep function behavior in relation to main thread activity in multithreading context
8 participants
@gbaraldi @vtjnash @vchuravy @algunion @danielwe @oscardssmith @cafaxo @brenhinkeller