Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GC scheduler refinements #52294

Merged
merged 1 commit into from
Dec 5, 2023
Merged

GC scheduler refinements #52294

merged 1 commit into from
Dec 5, 2023

Conversation

d-netto
Copy link
Member

@d-netto d-netto commented Nov 24, 2023

Supersedes #51061 and #51414.

Still needs more perf analysis.

@d-netto d-netto added performance Must go faster GC Garbage collector labels Nov 24, 2023
@d-netto d-netto requested a review from gbaraldi November 24, 2023 20:45
@d-netto d-netto force-pushed the dcn-gc-scheduler branch 8 times, most recently from 6543534 to ecfed25 Compare November 29, 2023 21:31
@gbaraldi gbaraldi requested a review from vchuravy November 29, 2023 21:59
@d-netto d-netto force-pushed the dcn-gc-scheduler branch 9 times, most recently from c195a43 to 0078148 Compare November 30, 2023 03:27
@d-netto
Copy link
Member Author

d-netto commented Dec 4, 2023

Bump @gbaraldi and @vchuravy, since this may help removing #51044 from the 1.10 milestone.

src/gc.c Show resolved Hide resolved
src/gc.c Show resolved Hide resolved
@gbaraldi gbaraldi merged commit e26c257 into master Dec 5, 2023
7 checks passed
@gbaraldi gbaraldi deleted the dcn-gc-scheduler branch December 5, 2023 16:47
@gbaraldi gbaraldi added the backport 1.10 Change should be backported to the 1.10 release label Dec 5, 2023
@topolarity
Copy link
Member

Thanks for a careful and conservative implementation here @d-netto - Very happy to have this fixed 🎉

d-netto added a commit to RelationalAI/julia that referenced this pull request Dec 7, 2023
d-netto added a commit to RelationalAI/julia that referenced this pull request Dec 7, 2023
@KristofferC KristofferC mentioned this pull request Dec 12, 2023
17 tasks
KristofferC pushed a commit that referenced this pull request Dec 12, 2023
Supersedes #51061 and
#51414.

Still needs more perf analysis.

(cherry picked from commit e26c257)
d-netto added a commit to RelationalAI/julia that referenced this pull request Dec 13, 2023
d-netto added a commit to RelationalAI/julia that referenced this pull request Dec 14, 2023
d-netto added a commit to RelationalAI/julia that referenced this pull request Dec 14, 2023
KristofferC added a commit that referenced this pull request Dec 17, 2023
Backported PRs:
- [x] #51234 <!-- Fix getfield codegen for tuple inputs and unknown
symbol fields. -->
- [x] #52170 <!-- fix invalidations related to `ismutable` -->
- [x] #52342 <!-- Add single-term multiplication for `AbstractQ` on
v1.10 and above -->
- [x] #52333 <!-- bugfix for dot of Hermitian{noncommutative} -->
- [x] #52407 <!-- channels: fix memory ordering violation in iterate -->
- [x] #52405 <!-- Bump LLVM to 15.0.7+10 to fix GC issue -->
- [x] #52441 <!-- Remove `Pkg` dependency from `SuiteSparse_jll` -->
- [x] #52367 <!-- docs: add notes about scratchspaces in depot -->
- [x] #52456 <!-- Make `jl_write_coverage_data` dllexported again -->
- [x] #52294 <!-- GC scheduler refinements -->
- [x] #52359 <!-- make custom log macros work -->
- [x] #52548
@KristofferC KristofferC removed the backport 1.10 Change should be backported to the 1.10 release label Dec 17, 2023
d-netto added a commit to RelationalAI/julia that referenced this pull request Jan 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
GC Garbage collector performance Must go faster
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants