Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RAI-19749] GC scheduler refinements (#52294) #117

Merged
merged 1 commit into from
Dec 14, 2023

Conversation

d-netto
Copy link
Member

@d-netto d-netto commented Dec 7, 2023

PR Description

Backports JuliaLang#52294.

Requirements for merging:

@d-netto d-netto requested a review from kpamnany December 7, 2023 20:31
@github-actions github-actions bot added port-to-v1.10 This change should apply to Julia v1.10 builds port-to-master This change should apply to all future Julia builds port-to-v1.9 This change should apply to Julia v1.9 builds labels Dec 7, 2023
@d-netto d-netto removed port-to-v1.10 This change should apply to Julia v1.10 builds port-to-master This change should apply to all future Julia builds labels Dec 7, 2023
@d-netto d-netto force-pushed the dcn-new-gc-scheduler branch from 8d6ce0c to 00b3a0b Compare December 7, 2023 21:28
@d-netto d-netto changed the title GC scheduler refinements (#52294) [RAI-19749] GC scheduler refinements (#52294) Dec 8, 2023
@d-netto d-netto force-pushed the dcn-new-gc-scheduler branch from 00b3a0b to 4efeb94 Compare December 13, 2023 15:10
@d-netto
Copy link
Member Author

d-netto commented Dec 13, 2023

Bump @kpamnany.

@kpamnany
Copy link
Collaborator

There seems to be a clear regression for MMI. It'd be good to understand why?

@d-netto
Copy link
Member Author

d-netto commented Dec 13, 2023

This dashboard that you linked refers to the old commit, which was on top of the 4k pages PR. The regression there is unsurprising because of this.

Given that we reverted this 4k pages commit, I've rebased the branch and pushed a new commit to raicode. We should wait to see what the results are with 16k pages, which will allows us to better isolate the performance effects from this patch.

Copy link
Collaborator

@kpamnany kpamnany left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving to remove the blocker but please confirm the benchmark perf before merging.

@d-netto d-netto merged commit dad5588 into v1.9.2+RAI Dec 14, 2023
1 check passed
@d-netto d-netto deleted the dcn-new-gc-scheduler branch December 14, 2023 13:53
@d-netto d-netto removed the port-to-v1.9 This change should apply to Julia v1.9 builds label Jan 2, 2024
github-actions bot pushed a commit that referenced this pull request Dec 16, 2024
Stdlib: SHA
URL: https://github.com/JuliaCrypto/SHA.jl.git
Stdlib branch: master
Julia branch: master
Old commit: aaf2df6
New commit: 8fa221d
Julia version: 1.12.0-DEV
SHA version: 0.7.0(Does not match)
Bump invoked by: @inkydragon
Powered by:
[BumpStdlibs.jl](https://github.com/JuliaLang/BumpStdlibs.jl)

Diff:
JuliaCrypto/SHA.jl@aaf2df6...8fa221d

```
$ git log --oneline aaf2df6..8fa221d
8fa221d ci: update doctest config (#120)
346b359 ci: Update ci config (#115)
aba9014 Fix type mismatch for `shake/digest!` and setup x86 ci (#117)
0b76d04 Merge pull request #114 from JuliaCrypto/dependabot/github_actions/codecov/codecov-action-5
5094d9d Update .github/workflows/CI.yml
45596b1 Bump codecov/codecov-action from 4 to 5
230ab51 test: remove outdate tests (#113)
7f25aa8 rm: Duplicated const alias (#111)
aa72f73 [SHA3] Fix padding special-case (#108)
3a01401 Delete Manifest.toml (#109)
da351bb Remvoe all getproperty funcs (#99)
4eee84f Bump codecov/codecov-action from 3 to 4 (#104)
15f7dbc Bump codecov/codecov-action from 1 to 3 (#102)
860e6b9 Bump actions/checkout from 2 to 4 (#103)
8e5f0ea Add dependabot to auto update github actions (#100)
4ab324c Merge pull request #98 from fork4jl/sha512-t
a658829 SHA-512: add ref to NIST standard
11a4c73 Apply suggestions from code review
969f867 Merge pull request #97 from fingolfin/mh/Vector
b1401fb SHA-512: add NIST test
4d7091b SHA-512: add to docs
09fef9a SHA-512: test SHA-512/224, SHA-512/256
7201b74 SHA-512: impl SHA-512/224, SHA-512/256
4ab85ad Array -> Vector
8ef91b6 fixed bug in padding for shake, addes testcases for full code coverage (#95)
88e1c83 Remove non-existent property (#75)
068f85d shake128,shake256: fixed typo in export declarations (#93)
176baaa SHA3 xof shake128 and shake256  (#92)
e1af7dd Hardcode doc edit backlink
```

Co-authored-by: Dilum Aluthge <dilum@aluthge.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants