Quickfix: prevent despecialisation of annotations list #53155
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In f117a50 code modifying annotations via list comprehensions was introduced. However, when (1) there are annotations present and (2) all annotations are filtered out, this comprehension is inferred to a wider type incompatible with the AnnotatedString constructor. This can be fixed by changing the first element of the tuple to directly use the UnitRange{Int} constructor, which stops it being inferred as an Any.
tecosaur
force-pushed
the
quickfix-annotio-type-inference
branch
from
093ee91 to
8f83286
Compare
|
I can confirm that test failures are completely unrelated (it's just the Mingw32 Windows builds). For any committers who stumble across this, this should be a pretty easy merge 🤞. |
oscardssmith
approved these changes
Feb 4, 2024
|
I do wonder whether the AnnotatedString constructor should be widened, but this looks reasonable to me. |
|
It used to accept a whole variety of forms, but I recall some thinking along the lines of it being better to widen as needs arise than pre-emptively. Thanks for taking a look at this! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In f117a50 code modifying annotations via list comprehensions was
introduced. However, when (1) there are annotations present and (2) all
annotations are filtered out, this comprehension is inferred to a wider
type incompatible with the AnnotatedString constructor. This can be
fixed by changing the first element of the tuple to directly use the
UnitRange{Int} constructor, which stops it being inferred as an Any.