Add ABIOverride type for def field #56555
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Keno
force-pushed
the
kf/abioverwrite
branch
2 times, most recently
from
31ee1b4 to
52285b4
Compare
|
Per discussion with various folks, we'd prefer to use the |
Keno
force-pushed
the
kf/abioverwrite
branch
from
52285b4 to
5f1eb66
Compare
vchuravy
changed the title
topolarity
reviewed
Dec 17, 2024
Keno
force-pushed
the
kf/abioverwrite
branch
from
5f1eb66 to
46388cf
Compare
Keno
changed the title
Keno
force-pushed
the
kf/abioverwrite
branch
3 times, most recently
from
d7e8c58 to
4690885
Compare
topolarity
reviewed
Dec 18, 2024
Keno
force-pushed
the
kf/abioverwrite
branch
4 times, most recently
from
c40f362 to
af8b410
Compare
|
Alright, I think this is basically working. Still needs some tests and possibly some minor tweaks, but I'd like to get it merged, so that the helpers for looking through |
Together with #54899, this PR is intending to replicate the functionality of #54373, which allowed particular specializations to have a different ABI signature than what would be suggested by the MethodInstance's `specTypes` field. This PR handles that by adding a special `ABIOverwrite` type, which, when placed in the `def` field of a `CodeInstance` instructs the system to use the given signature instead.
Keno
force-pushed
the
kf/abioverwrite
branch
from
af8b410 to
0cfeee8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Together with #54899, this PR is intending to replicate the functionality of #54373, which allowed particular specializations to have a different ABI signature than what would be suggested by the MethodInstance's
specTypesfield. This PR handles that by adding a specialABIOverwritetype, which, when placed in theownerfield of aCodeInstanceinstructs the system to use the given signature instead.