Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch LLVM reflection utilities to be CodeInstance based #56876

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Keno
Copy link
Member

@Keno Keno commented Dec 20, 2024

This is a natural continuation of the stream of work begun in #53219. In particular, with #56555, it is important to be able to pass a CodeInstance, since the ABI may be overwritten and without knowing that, codegen will generated incorrect code for the CodeInstance.

This is a natural continuation of the stream of work begun in #53219.
In particular, with #56555, it is important to be able to pass a
CodeInstance, since the ABI may be overwritten and without knowing
that, codegen will generated incorrect code for the CodeInstance.
Copy link
Member

@vtjnash vtjnash left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The src argument is not optional (nullable)

@Keno
Copy link
Member Author

Keno commented Dec 20, 2024

The src argument is not optional (nullable)

It is in this PR.

@vtjnash
Copy link
Member

vtjnash commented Dec 20, 2024

Then this PR cannot be merged, since it cannot be optional, as codegen has no other reliable way to get that

@Keno
Copy link
Member Author

Keno commented Dec 20, 2024

It just picks out the .inferred field and errors if its not there. The use case is for reflecting on CodeInstances that have the field. If they don't have the field, it obviously needs to be passed in separately.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants