Version 5.10.0 #129
Merged
Version 5.10.0 #129
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This provides a flexible mechanism through which LBT's autodetection facilities can be overridden. It enables debugging strange behaviors without needing to recompile LBT from scratch to disable a certain layer of its behavior.
staticfloat
force-pushed
the
sf/env_overrides
branch
5 times, most recently
from
98cab58
to
c09754b
Compare
Windows x64 automatically forces return values onto the stack if they are larger than 64 bits wide [0]. This causes return values from e.g. `zdotc` to be pushed onto a secret first argument, but not the return values from e.g. `cdotc`. To address this, we add a new complex return style, "Float Normal, Double Argument", to specify that `complex float`-returning functions use the normal return style, whereas `complex double`-returning functions use the argument return style. This should fix JuliaLinearAlgebra/BLISBLAS.jl#15 [0] https://learn.microsoft.com/en-us/cpp/build/x64-calling-convention?view=msvc-170
Our new `LBT_FORCE_RETSTYLE => ARGUMENT` doesn't work so well when it's already `ARGUMENT` on Windows x64.
staticfloat
force-pushed
the
sf/env_overrides
branch
from
c09754b
to
237afdf
Compare
If a user wants to use MKL on i686, we unfortunately need some workarounds for certain function calls. Until we come up with an autodetection strategy that works on i686 as well as x86_64, we can make use of the new environment variable-based overrides to make things work. Let's test that on i686 on CI.
staticfloat
changed the title
LBT_FORCE_* environment variable overrides
staticfloat
added a commit
to JuliaLang/julia
that referenced
this pull request
Jun 13, 2024
This release fixes issues with complex valued returns from functions such as `cdotc` on Windows x64. See this discussion [0] for initial diagnosis, and this PR [1] for the relevant fixes. [0] JuliaLinearAlgebra/BLISBLAS.jl#15 [1] JuliaLinearAlgebra/libblastrampoline#129
staticfloat
added a commit
to JuliaLang/julia
that referenced
this pull request
Jun 14, 2024
This release fixes issues with complex valued returns from functions such as `cdotc` on Windows x64. See this discussion [0] for initial diagnosis, and this PR [1] for the relevant fixes. [0] JuliaLinearAlgebra/BLISBLAS.jl#15 [1] JuliaLinearAlgebra/libblastrampoline#129
staticfloat
added a commit
to JuliaLang/julia
that referenced
this pull request
Jun 14, 2024
This release fixes issues with complex valued returns from functions such as `cdotc` on Windows x64. See this discussion [0] for initial diagnosis, and this PR [1] for the relevant fixes. [0] JuliaLinearAlgebra/BLISBLAS.jl#15 [1] JuliaLinearAlgebra/libblastrampoline#129
KristofferC
pushed a commit
to JuliaLang/julia
that referenced
this pull request
Jul 23, 2024
This release fixes issues with complex valued returns from functions such as `cdotc` on Windows x64. See this discussion [0] for initial diagnosis, and this PR [1] for the relevant fixes. [0] JuliaLinearAlgebra/BLISBLAS.jl#15 [1] JuliaLinearAlgebra/libblastrampoline#129 (cherry picked from commit 3054c00)
KristofferC
pushed a commit
to JuliaLang/julia
that referenced
this pull request
Jul 24, 2024
This release fixes issues with complex valued returns from functions such as `cdotc` on Windows x64. See this discussion [0] for initial diagnosis, and this PR [1] for the relevant fixes. [0] JuliaLinearAlgebra/BLISBLAS.jl#15 [1] JuliaLinearAlgebra/libblastrampoline#129 (cherry picked from commit 3054c00)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This provides a flexible mechanism through which LBT's autodetection facilities can be overridden. It enables debugging strange behaviors without needing to recompile LBT from scratch to disable a certain layer of its behavior.
This also adds support for
COMPLEX_RETSTYLE_FNDAfor Windows x64, and fixes CI on i686.