Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Version 5.10.0 #129

Merged
merged 5 commits into from
Jun 13, 2024
Merged

Version 5.10.0 #129

merged 5 commits into from
Jun 13, 2024

Commits on Jun 12, 2024

  1. Add LBT_FORCE_* environment variable overrides 

    This provides a flexible mechanism through which LBT's autodetection
facilities can be overridden.  It enables debugging strange behaviors
without needing to recompile LBT from scratch to disable a certain layer
of its behavior.
    @staticfloat
    staticfloat committed Jun 12, 2024
    Configuration menu
    Copy the full SHA
    1a3c7f2 View commit details
    Browse the repository at this point in the history

  2. Add COMPLEX_RETSTYLE_FNDA for Windows x64 

    Windows x64 automatically forces return values onto the stack if they
are larger than 64 bits wide [0].  This causes return values from e.g.
`zdotc` to be pushed onto a secret first argument, but not the return
values from e.g. `cdotc`.

To address this, we add a new complex return style, "Float Normal,
Double Argument", to specify that `complex float`-returning functions
use the normal return style, whereas `complex double`-returning
functions use the argument return style.

This should fix JuliaLinearAlgebra/BLISBLAS.jl#15

[0] https://learn.microsoft.com/en-us/cpp/build/x64-calling-convention?view=msvc-170
    @staticfloat
    staticfloat committed Jun 12, 2024
    Configuration menu
    Copy the full SHA
    c953e91 View commit details
    Browse the repository at this point in the history

  3. Move to cdotc instead of zdotc to avoid Windows x64 confusion 

    Our new `LBT_FORCE_RETSTYLE => ARGUMENT` doesn't work so well when it's
already `ARGUMENT` on Windows x64.
    @staticfloat
    staticfloat committed Jun 12, 2024
    Configuration menu
    Copy the full SHA
    52aeef8 View commit details
    Browse the repository at this point in the history

  4. Update .gitignore

    @staticfloat
    staticfloat committed Jun 12, 2024
    Configuration menu
    Copy the full SHA
    237afdf View commit details
    Browse the repository at this point in the history

  5. Allow for overriding workarounds even when autodetection is unavailable 

    If a user wants to use MKL on i686, we unfortunately need some
workarounds for certain function calls.  Until we come up with an
autodetection strategy that works on i686 as well as x86_64, we can make
use of the new environment variable-based overrides to make things work.
Let's test that on i686 on CI.
    @staticfloat
    staticfloat committed Jun 12, 2024
    Configuration menu
    Copy the full SHA
    11b29ac View commit details
    Browse the repository at this point in the history