Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

manifold_point_error can't return multiple independent issues #47

Closed
mateuszbaran opened this issue Nov 22, 2019 · 2 comments · Fixed by #207
Closed

manifold_point_error can't return multiple independent issues #47

mateuszbaran opened this issue Nov 22, 2019 · 2 comments · Fixed by #207
Labels
enhancement New feature or request

Comments

@mateuszbaran
Copy link
Member

As discussed in #46 , the current approach to error checking allows reporting only a single error at a time. For some manifolds (for example product and power manifolds) multiple independent issues may arise at the same time. We should have a way to report all of them in manifold_point_error.

Ref #24 .

@sethaxen sethaxen added the enhancement New feature or request label Jan 24, 2020
@kellertuer
Copy link
Member

I think I found a good solution, for power and product, within check_manifold_point or check_tangent_vector do

  1. call all checks, collect results in a vector,
  2. if all entries are nothing (maybe Filter out nothings and check whether empty)
  3. if the result of 2 is not empty, wrap that in a CompositeException https://docs.julialang.org/en/v1/base/base/#Base.CompositeException
    return that.

@mateuszbaran
Copy link
Member Author

That is a good solution.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants