Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Transition to ManifoldsBase.jl #46

Merged
merged 9 commits into from
Nov 27, 2019
Merged

Transition to ManifoldsBase.jl #46

merged 9 commits into from
Nov 27, 2019

Conversation

mateuszbaran
Copy link
Member

This PR transitions Manifolds.jl to the interface from ManifoldsBase.jl. Simultaneously, it resolves issue #24 .

kellertuer
kellertuer reviewed Nov 20, 2019
View reviewed changes
Copy link
Member

@kellertuer kellertuer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the transition, yes we changed a few things during transistion, namely the decorator is now without SimpleTraits, so the whole project lost a dependency and the errors are different – both is here – great :)

src/ProductManifold.jl Show resolved Hide resolved
src/ProductManifold.jl Outdated
perr = manifold_point_error(M, x)
perr === nothing || return perr
for t ∈ ziptuples(M.manifolds, x.parts, v.parts)
err = tangent_vector_error(t...; kwargs...)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is also the same as above.

src/ProductManifold.jl Outdated
perr = manifold_point_error(M, x)
perr === nothing || return perr
for t ∈ ziptuples(M.manifolds, x.parts, v.parts)
err = tangent_vector_error(t...; kwargs...)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is the same point as above for manifold points

@kellertuer
Copy link
Member

The Readme should link to the ManifoldsBase – in the long run the Base part should be reflected better in the documentation, but I can do that also later.

@mateuszbaran mateuszbaran mentioned this pull request Nov 22, 2019
Closed
@codecov
Copy link

codecov bot commented Nov 22, 2019 •
edited
Loading

Codecov Report

Merging #46 into master will increase coverage by 2.24%.
The diff coverage is 84.28%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #46      +/-   ##
==========================================
+ Coverage   83.62%   85.87%   +2.24%     
==========================================
  Files          18       17       -1     
  Lines        1136      984     -152     
==========================================
- Hits          950      845     -105     
+ Misses        186      139      -47
Impacted Files Coverage Δ
src/Manifolds.jl 83.33% <ø> (+16.06%) ⬆️
src/Euclidean.jl 73.33% <ø> (ø) ⬆️
src/ProductManifold.jl 79.54% <100%> (+3.86%) ⬆️
src/SymmetricPositiveDefinite.jl 87.82% <100%> (+0.1%) ⬆️
src/Rotations.jl 89.55% <25%> (-2%) ⬇️
src/Sphere.jl 96.36% <75%> (-3.64%) ⬇️
src/Metric.jl 75.34% <75%> (-1.05%) ⬇️
src/PowerManifold.jl 91.66% <88.88%> (-0.65%) ⬇️
src/CholeskySpace.jl 96.77% <90%> (-3.23%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2660f7b...f6e2f43. Read the comment docs.

@mateuszbaran mateuszbaran mentioned this pull request Nov 25, 2019
Merged
@mateuszbaran
Copy link
Member Author

Let's wait with this until JuliaManifolds/ManifoldsBase.jl#15 is merged and 0.2.0 of ManifoldsBase.jl is tagged.

@mateuszbaran mateuszbaran mentioned this pull request Nov 26, 2019
Closed
@mateuszbaran
Copy link
Member Author

I think it's done, I'll merge this if CI passes.

@mateuszbaran
Copy link
Member Author

Finally CI is happy 🎉

@mateuszbaran mateuszbaran merged commit 7d0b639 into master Nov 27, 2019
@mateuszbaran mateuszbaran deleted the mbaran/manifolds-base branch January 20, 2020 22:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kellertuer kellertuer kellertuer approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mateuszbaran @kellertuer