Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changes power and product manifold to return CompositeExceptions. #207

Merged
merged 8 commits into from
Aug 2, 2020

Conversation

kellertuer
Copy link
Member

This should fix #47. Tests are still running fine, but that also means we never actually tested which errors are returned.

@codecov
Copy link

codecov bot commented Jul 29, 2020

Codecov Report

Merging #207 into master will increase coverage by 0.04%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #207      +/-   ##
==========================================
+ Coverage   94.87%   94.91%   +0.04%     
==========================================
  Files          61       61              
  Lines        3687     3679       -8     
==========================================
- Hits         3498     3492       -6     
+ Misses        189      187       -2     
Impacted Files Coverage Δ
src/manifolds/PowerManifold.jl 95.87% <100.00%> (+0.04%) ⬆️
src/manifolds/ProductManifold.jl 89.56% <100.00%> (+0.44%) ⬆️
src/manifolds/Euclidean.jl 91.76% <0.00%> (-0.10%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a7d88da...a68bb47. Read the comment docs.

@kellertuer kellertuer added the Ready-for-Review A label for pull requests that are feature-ready label Aug 2, 2020
@kellertuer kellertuer merged commit 049efae into master Aug 2, 2020
@kellertuer kellertuer removed the Ready-for-Review A label for pull requests that are feature-ready label Aug 6, 2020
@kellertuer kellertuer deleted the Introduce-CompositeException branch August 7, 2020 07:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

manifold_point_error can't return multiple independent issues
2 participants