Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix 0.6 abstract type declaration depwarn #73

Merged
merged 1 commit into from
Feb 12, 2017

Conversation

yuyichao
Copy link
Contributor

@yuyichao yuyichao commented Feb 11, 2017

DO NOT MERGE NOW!!!!

This requires JuliaLang/Compat.jl#325 and a new tag. I'm using this (and other) PR's to check if the implementation is correct.

Ready now.

@yuyichao
Copy link
Contributor Author

Compat tagged, CI reenabled.

@codecov-io
Copy link

Codecov Report

Merging #73 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master      #73   +/-   ##
=======================================
  Coverage   83.42%   83.42%           
=======================================
  Files           4        4           
  Lines         181      181           
=======================================
  Hits          151      151           
  Misses         30       30
Impacted Files Coverage Δ
src/FixedPointNumbers.jl 89.47% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 872675d...f1e4d5a. Read the comment docs.

@vchuravy vchuravy merged commit 048a560 into JuliaMath:master Feb 12, 2017
@timholy
Copy link
Member

timholy commented Feb 12, 2017

New release tagged, JuliaLang/METADATA.jl#7926.

@timholy
Copy link
Member

timholy commented Feb 12, 2017

Thanks for handling Compat and all these packages, @yuyichao. 💯

@yuyichao yuyichao deleted the yyc/0.6 branch February 12, 2017 00:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants