Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix an ambiguity on julia 0.6 #74

Merged
merged 1 commit into from
Feb 11, 2017
Merged

Fix an ambiguity on julia 0.6 #74

merged 1 commit into from
Feb 11, 2017

Conversation

timholy
Copy link
Member

@timholy timholy commented Feb 11, 2017

Sometimes, it's the simplest things that fail. Detected in a test failure for ImageFiltering, https://travis-ci.org/JuliaImages/ImageFiltering.jl/jobs/200619941.

@codecov-io
Copy link

Codecov Report

Merging #74 into master will increase coverage by 0.45%.

@@            Coverage Diff             @@
##           master      #74      +/-   ##
==========================================
+ Coverage   82.96%   83.42%   +0.45%     
==========================================
  Files           4        4              
  Lines         182      181       -1     
==========================================
  Hits          151      151              
+ Misses         31       30       -1
Impacted Files Coverage Δ
src/normed.jl 90.8% <100%> (+1.03%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9a1b40a...3bf4701. Read the comment docs.

@vchuravy
Copy link
Collaborator

We have the ambiguity tests currently turned off for v0.6 we should probably turn them on again, (there might have been a Base issue though)

@vchuravy vchuravy merged commit 872675d into master Feb 11, 2017
@vchuravy vchuravy deleted the teh/amb branch February 11, 2017 12:34
@timholy
Copy link
Member Author

timholy commented Feb 11, 2017

Agreed. Currently the problem is that Base reports a lot of ambiguities right now. Some of them are fictitious (JuliaLang/julia#20246, JuliaLang/julia#20567), others may be real.

I've sometimes used setdiff to "subtract off" ambiguities in Base from those in other modules. But when you're extending a Base method, that won't help.

@timholy
Copy link
Member Author

timholy commented Feb 11, 2017

Should have mentioned, the second of those bug reports was motivated by trying to turn on the ambiguity tests here. 😄

@timholy
Copy link
Member Author

timholy commented Feb 11, 2017

We'll want to tag again soon, but ideally we'd incorporate #73.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants