make ChainRulesCore dependency into an extension #421
Conversation
Codecov ReportBase: 91.87% // Head: 93.77% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## master #421 +/- ##
==========================================
+ Coverage 91.87% 93.77% +1.89%
==========================================
Files 14 14
Lines 2967 2908 -59
==========================================
+ Hits 2726 2727 +1
+ Misses 241 181 -60
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
|
Could you summarize the practical effect for those of us who have not followed the "weak dependency" feature progress? |
|
Sure, I'll summarize but also link to the docs: https://pkgdocs.julialang.org/dev/creating-packages/#Conditional-loading-of-code-in-packages-(Extensions) Basically, you can think of |
| @@ -91,7 +90,9 @@ include("gamma.jl") | |||
| include("gamma_inc.jl") | |||
| include("betanc.jl") | |||
| include("beta_inc.jl") | |||
| include("chainrules.jl") | |||
| if !isdefined(Base, :get_extension) | |||
There was a problem hiding this comment.
Do I understand correctly this PR is basically removing functionality for Julia v1.8-?
There was a problem hiding this comment.
That'd be pretty unfortunate :p.
There was a problem hiding this comment.
for Julia 1.8- my understanding is that it is the same as the old behavior (i.e. it loads ChainRulesCore unconditionally?)
|
Seems the PR is ready and the Registrator deployment is done? |
|
Yes! |
Shouldn't be merged until the Registrator deployment of JuliaRegistries/Registrator.jl#397 is done.