Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make ChainRulesCore, ChangesOfVariables, and InverseFunctions weak dependencies #62

Merged
merged 1 commit into from
Jan 26, 2023

Conversation

devmotion
Copy link
Member

By doing so, on Julia >= 1.9 support for these packages will be loaded only when the packages are loaded by the user (or some other package). Some more info about weak dependencies: https://pkgdocs.julialang.org/dev/creating-packages/#Conditional-loading-of-code-in-packages-(Extensions)

The PR is based on JuliaMath/SpecialFunctions.jl#421 and JuliaStats/StatsFuns.jl#153.

@devmotion devmotion force-pushed the dw/weakdeps branch 2 times, most recently from e236cf4 to 16dcc95 Compare January 25, 2023 23:29
@devmotion
Copy link
Member Author

@devmotion devmotion requested a review from tpapp January 25, 2023 23:39
Copy link
Collaborator

@tpapp tpapp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for doing this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants