-
Notifications
You must be signed in to change notification settings - Fork 140
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
prefix symbols with _ for 32-bit x86 Windows #238
Conversation
In a case that I believe can only be hit for Clang i686-*-windows-gnu (AKA MinGW), symbols in asm need to be prefixed with `_`. Fixes #237
I don't know about the non- |
@staticfloat Would you be able to take a look at this? Also, it would be so much easier to merge these if we had CI working through gh actions. |
I talked it over with @vtjnash and we both agree that supporting non- |
Co-authored-by: Elliot Saba <staticfloat@gmail.com>
This one didn't build on my mac - so I had to revert it.
|
Yeah, it appears that |
May need a new PR - and while I now have CI running, I don't think I am able to set up the windows CI correctly for x86. |
In a case that I believe can only be hit for Clang i686-*-windows-gnu (AKA MinGW), symbols in asm need to be prefixed with
_
. Fixes #237