-
Notifications
You must be signed in to change notification settings - Fork 51
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Linkage error when cross-compiling for i686-pc-windows-gnu
#620
Comments
Hello again! So it appears that either the bindings generated incorrectly or the build didn't properly prefix the symbols (or both). The I seem to remember that symbols for 32-bit Windows platforms (i686) were always prefixed with an additional underscore, i.e., like Could it be that external bindgen (i.e., bindgen-cli) was used? I'm looking at the logic here with suspicion. I'll try to reproduce this build error locally on my Windows box to diagnose. Hopefully, I'll have a diagnosis soon! 🤞 |
@justsmth Thanks for the prompt reply!
After some investigation I do believe you should adjust the prefix for mingw:
|
Ok, so I think the problem only affects "external" bindgen, not the "internal' bindgen. (Assuming this is correct) a workaround would be to enable the I put up a draft PR here: I plan to add some testing for this, then mark the PR ready for review. I apologize for this gap in our test coverage! Hopefully, I can quickly figure our why the CI runner on GitHub was having trouble with this target so we can prevent a future regression. Thanks for reporting and for helping with the diagnosis! |
@justsmth It looks like that PR has been merged. Thanks again! BTW do you have a specific timeline for the next release? |
Yeah, the plan is to have a release within this next week. Possibly, Tuesday or Wednesday. It should have this and some other important changes. 😀 |
@justsmth Just one question: #627 seems to be the PR that I should be waiting for, but the release is still not available on crates.io yet after it being merged, is this expected? |
Yeah, we're still working on completing changes for I'll be sure to update here when the new release is posted. Thanks! 😃 |
Hello again! We just released aws-lc-rs v1.12.0. 🎉 We believe our latest release resolves the issue reported here. This issue will now be closed. If you continue to see this or other problems after upgrading, feel free to re-open this issue or open a new one. Thanks for your help in improving our library! |
Problem:
Hi! It's me again 🙇
This time, Rustup's new release promotion PR (rust-lang/rustup#4105) has been blocked by a failed
i686-pc-windows-gnu
CI workflow.We use the same setup for i686 and x86_64 Windows GNU environments:
https://github.com/rust-lang/rustup/blob/14470b2b14c10e1578d0d343c4a4f8445cd96a0f/.github/workflows/ci.yaml#L369-L406
... however only the i686 build failed, with the following log (the original log is over 65535 characters so cannot be uploaded in full):
Log
https://github.com/rust-lang/rustup/actions/runs/12162420263/job/33919348975?pr=4105
Many thanks in advance!
Relevant details
AWS-LC for Rust versions or commit:
System information: GitHub Actions Runner (Windows Server)
The text was updated successfully, but these errors were encountered: