[Cbc] Remove patch #2668
Merged
[Cbc] Remove patch #2668
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
giordano
reviewed
Mar 11, 2021
odow
added a commit
to odow/General
that referenced
this pull request
Mar 15, 2021
The issue arose because Cbc_jll@2.10.5+1 was previously released, but due to some compatibility issues, the next version released was 2.10.3. We recently re-compiled Cbc pointing at the upstream 2.10.5, which got released as 2.10.5+2 JuliaRegistries#31558 JuliaPackaging/Yggdrasil#2668 However, we didn't account for the version incompatibilities (it seems like `[Compat]` can't handle `+N` version revisions).
giordano
pushed a commit
to JuliaRegistries/General
that referenced
this pull request
Mar 15, 2021
* Fix version requirements for Cbc_jll The issue arose because Cbc_jll@2.10.5+1 was previously released, but due to some compatibility issues, the next version released was 2.10.3. We recently re-compiled Cbc pointing at the upstream 2.10.5, which got released as 2.10.5+2 #31558 JuliaPackaging/Yggdrasil#2668 However, we didn't account for the version incompatibilities (it seems like `[Compat]` can't handle `+N` version revisions). * Yank old versions
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This technically breaking for users of
Cbc_jll@2.10.5, but we're having some issues JuliaRegistries/General#31558 anyway, so we may as well remove this patch and see what happens.The only downstream library which consumes Cbc_jll is Cbc.jl, and that pins Cbc_jll@2.10.3:
https://github.com/jump-dev/Cbc.jl/blob/bd2b078dc7930dac6f8ac0912cea873dd1530312/Project.toml#L17
Instead of patching upstream, we should work around the issue in Cbc.jl, otherwise people installing from non-jll builds will encounter hard-to-debug errors: jump-dev/Cbc.jl#154.