-
Notifications
You must be signed in to change notification settings - Fork 463
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New version: Cbc_jll v2.10.5+2 #31558
Conversation
Your
Note that the guidelines are only required for the pull request to be merged automatically. However, it is strongly recommended to follow them, since otherwise the pull request needs to be manually reviewed and merged by a human. After you have fixed the AutoMerge issues, simple retrigger Registrator, which will automatically update this pull request. You do not need to change the version number in your If you do not want to fix the AutoMerge issues, please post a comment explaining why you would like this pull request to be manually merged. If you want to prevent this pull request from being auto-merged, simply leave a comment. If you want to post a comment without blocking auto-merging, you must include the text |
[noblock] Weird. I was under the impression that if it passed Yggdrasil, it was okay to load. I'll take a look |
That's not always the case. I'm also a bit confused by the error because it works locally, but I'd tend to trust CI run here, it's a more minimal system than my computer [noblock] |
[noblock] It seems like we built 2.10.5 initially JuliaPackaging/Yggdrasil#509 (comment), but for some reason changed that to 2.10.3 jump-dev/Cbc.jl#133 (comment). (I can't find/don't remember why. @ViralBShah has probably also forgotten.) I'm confused by the error because |
Yeah, I don't know why we had older versions of 2.10.5. If you want we can try to merge this PR and see what happens. It works for me as well locally, so it isn't straightforward for me to debug (would need to log into a GitHub Actions runner....) [noblock] |
Cbc.jl uses Cbc_jll pinned at 2.10.3, so nothing should break if we merge this. I wonder if we should just remove the patch and release as 2.10.5+3, since it's unlikely that anyone is actually using Cbc_jll instead of Cbc.jl. [noblock] |
UUID: 38041ee0-ae04-5750-a4d2-bb4d0d83d27d Repo: https://github.com/JuliaBinaryWrappers/Cbc_jll.jl.git Tree: 5d24ea46edebb4f067b180cfc092a45d4d2c48b3 Registrator tree SHA: 4c45181064d4fce25830ea985fc9766d565870ed
146ae7d
to
2272ec3
Compare
Still same error. I don't understand it and frankly and I don't have much time to debug it while it works locally (tried again just now). I'm going to merge it, but please report to Yggdrasil if you know of issues |
Thanks for the time you spend on this. I'll have a go with the JLL. |
The issue arose because Cbc_jll@2.10.5+1 was previously released, but due to some compatibility issues, the next version released was 2.10.3. We recently re-compiled Cbc pointing at the upstream 2.10.5, which got released as 2.10.5+2 JuliaRegistries#31558 JuliaPackaging/Yggdrasil#2668 However, we didn't account for the version incompatibilities (it seems like `[Compat]` can't handle `+N` version revisions).
* Fix version requirements for Cbc_jll The issue arose because Cbc_jll@2.10.5+1 was previously released, but due to some compatibility issues, the next version released was 2.10.3. We recently re-compiled Cbc pointing at the upstream 2.10.5, which got released as 2.10.5+2 #31558 JuliaPackaging/Yggdrasil#2668 However, we didn't account for the version incompatibilities (it seems like `[Compat]` can't handle `+N` version revisions). * Yank old versions
Autogenerated JLL package registration