Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New version: Cbc_jll v2.10.5+2 #31558

Merged
merged 2 commits into from
Mar 11, 2021
Merged

Conversation

jlbuild
Copy link
Contributor

@jlbuild jlbuild commented Mar 9, 2021

Autogenerated JLL package registration

@jlbuild jlbuild temporarily deployed to stopwatch March 9, 2021 08:22 Inactive
@giordano giordano temporarily deployed to stopwatch March 9, 2021 23:24 Inactive
@giordano giordano temporarily deployed to stopwatch March 9, 2021 23:35 Inactive
@github-actions
Copy link
Contributor

github-actions bot commented Mar 9, 2021

Your new version pull request does not meet the guidelines for auto-merging. Please make sure that you have read the General registry README. The following guidelines were not met:

  • I was not able to load the package (i.e. import Cbc_jll failed). See the CI logs for details.

Note that the guidelines are only required for the pull request to be merged automatically. However, it is strongly recommended to follow them, since otherwise the pull request needs to be manually reviewed and merged by a human.

After you have fixed the AutoMerge issues, simple retrigger Registrator, which will automatically update this pull request. You do not need to change the version number in your Project.toml file (unless of course the AutoMerge issue is that you skipped a version number, in which case you should change the version number).

If you do not want to fix the AutoMerge issues, please post a comment explaining why you would like this pull request to be manually merged.


If you want to prevent this pull request from being auto-merged, simply leave a comment. If you want to post a comment without blocking auto-merging, you must include the text [noblock] in your comment.

@giordano giordano closed this Mar 9, 2021
@giordano giordano reopened this Mar 9, 2021
@giordano giordano temporarily deployed to stopwatch March 9, 2021 23:55 Inactive
@odow
Copy link
Contributor

odow commented Mar 10, 2021

[noblock] Weird. I was under the impression that if it passed Yggdrasil, it was okay to load. I'll take a look

@giordano
Copy link
Member

That's not always the case. I'm also a bit confused by the error because it works locally, but I'd tend to trust CI run here, it's a more minimal system than my computer

[noblock]

@odow
Copy link
Contributor

odow commented Mar 10, 2021

[noblock]

It seems like we built 2.10.5 initially JuliaPackaging/Yggdrasil#509 (comment), but for some reason changed that to 2.10.3 jump-dev/Cbc.jl#133 (comment). (I can't find/don't remember why. @ViralBShah has probably also forgotten.)

I'm confused by the error because getRowNames has been in Clp forever, and there were only minor changes between Cbc 2.10.3 and 2.10.5: coin-or/Cbc@releases/2.10.3...releases/2.10.5

@giordano
Copy link
Member

giordano commented Mar 11, 2021

Yeah, I don't know why we had older versions of 2.10.5. If you want we can try to merge this PR and see what happens. It works for me as well locally, so it isn't straightforward for me to debug (would need to log into a GitHub Actions runner....)

[noblock]

@odow
Copy link
Contributor

odow commented Mar 11, 2021

Cbc.jl uses Cbc_jll pinned at 2.10.3, so nothing should break if we merge this. I wonder if we should just remove the patch and release as 2.10.5+3, since it's unlikely that anyone is actually using Cbc_jll instead of Cbc.jl.

[noblock]

UUID: 38041ee0-ae04-5750-a4d2-bb4d0d83d27d
Repo: https://github.com/JuliaBinaryWrappers/Cbc_jll.jl.git
Tree: 5d24ea46edebb4f067b180cfc092a45d4d2c48b3

Registrator tree SHA: 4c45181064d4fce25830ea985fc9766d565870ed
@jlbuild jlbuild force-pushed the registrator/cbc_jll/38041ee0/v2.10.5+2 branch from 146ae7d to 2272ec3 Compare March 11, 2021 01:26
@jlbuild jlbuild temporarily deployed to stopwatch March 11, 2021 01:26 Inactive
@giordano
Copy link
Member

Still same error. I don't understand it and frankly and I don't have much time to debug it while it works locally (tried again just now). I'm going to merge it, but please report to Yggdrasil if you know of issues

@giordano giordano merged commit 91c6dbc into master Mar 11, 2021
@giordano giordano deleted the registrator/cbc_jll/38041ee0/v2.10.5+2 branch March 11, 2021 01:36
@odow
Copy link
Contributor

odow commented Mar 11, 2021

Thanks for the time you spend on this. I'll have a go with the JLL.

odow added a commit to odow/General that referenced this pull request Mar 15, 2021
The issue arose because Cbc_jll@2.10.5+1 was previously released,
but due to some compatibility issues, the next version released
was 2.10.3.

We recently re-compiled Cbc pointing at the upstream 2.10.5, which
got released as 2.10.5+2
JuliaRegistries#31558
JuliaPackaging/Yggdrasil#2668

However, we didn't account for the version incompatibilities (it seems like
`[Compat]` can't handle `+N` version revisions).
giordano pushed a commit that referenced this pull request Mar 15, 2021
* Fix version requirements for Cbc_jll

The issue arose because Cbc_jll@2.10.5+1 was previously released,
but due to some compatibility issues, the next version released
was 2.10.3.

We recently re-compiled Cbc pointing at the upstream 2.10.5, which
got released as 2.10.5+2
#31558
JuliaPackaging/Yggdrasil#2668

However, we didn't account for the version incompatibilities (it seems like
`[Compat]` can't handle `+N` version revisions).

* Yank old versions
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants