Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added contributing file #171

Merged
merged 2 commits into from
Feb 19, 2022
Merged

added contributing file #171

merged 2 commits into from
Feb 19, 2022

Conversation

crsl4
Copy link
Member

@crsl4 crsl4 commented Jan 28, 2022

Created md file with guidelines for contributors.

@crsl4 crsl4 requested a review from cecileane January 28, 2022 14:07
@crsl4
Copy link
Member Author

crsl4 commented Jan 28, 2022

Uhm, strange failed tests starting with

Test Failed at /home/runner/work/PhyloNetworks.jl/PhyloNetworks.jl/test/test_correctLik.jl:70
  Expression: estNet.loglik < 0.00217
   Evaluated: 0.005312336927813476 < 0.00217

I wonder if we are testing with Julia 1.7 already. Have to check!

@cecileane
Copy link
Member

yes: ci.yml asks the tests to run on version 1 of julia, which is treated as the latest stable 1.x version. The failing tests seem to be after we use the random number generator.

There are several overdue updated: julia 1.7, and 2 pull requests to update compatibility with CSV 0.10 (#169) and with BioSequences v3 (#167). I don't have the bandwidth to do this now.

@cecileane
Copy link
Member

I like the simplicity and focus on essentials. go for it!

@cecileane cecileane merged commit 0dba319 into master Feb 19, 2022
@cecileane cecileane deleted the contributing branch February 19, 2022 05:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants