Update nulldeviance for models with no intercept #175
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #175 +/- ##
==========================================
- Coverage 85.88% 85.88% -0.01%
==========================================
Files 29 29
Lines 11819 11823 +4
==========================================
+ Hits 10151 10154 +3
- Misses 1668 1669 +1
Continue to review full report at Codecov.
|
|
Thank you so much Paul! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update the
nulldeviancefunction to deal with models without an intercept.The updated function should be consistent with the new definition proposed in JuliaStats/StatsAPI.jl#14.
The implementation is similar to JuliaStats/GLM.jl#481, with a redefined
hasinterceptfunction forPhyloNetworkLinearModels.