Error when the network has negative or missing branches for phylolm #180
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #180 +/- ##
==========================================
- Coverage 86.03% 85.94% -0.09%
==========================================
Files 29 29
Lines 11842 11850 +8
==========================================
- Hits 10188 10185 -3
- Misses 1654 1665 +11
Continue to review full report at Codecov.
|
|
I'll suggest a few changes. for example, the new function to check for missing / negative branch lengths could be very useful elsewhere. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See issue #179.
This just throws an explicit error early to avoid a confusing Cholesky related error later.
Let me know if you see any better way to deal with this, or if I missed something.