Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix NLopt build #73

Merged
merged 2 commits into from
Mar 29, 2018
Merged

Fix NLopt build #73

merged 2 commits into from
Mar 29, 2018

Conversation

pbastide
Copy link
Member

  • Tweak .travis.ylm to install libnlopt0 before hand (for linux build)
  • Remove call to master branch for osx (not needed anymore since last release of NLopt).

@codecov
Copy link

codecov bot commented Mar 29, 2018

Codecov Report

Merging #73 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff           @@
##           master     #73   +/-   ##
======================================
  Coverage    74.7%   74.7%           
======================================
  Files          22      22           
  Lines        8299    8299           
======================================
  Hits         6200    6200           
  Misses       2099    2099

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6cb7e22...51bf1f0. Read the comment docs.

@cecileane
Copy link
Member

Hi Claudia, could you possibly double-check the set-up for Codecov.io and Coveralls for PhyloNetworks? It seems simple based on these instructions, from Codecov and for Coveralls. I modified the travis file to use the coverage scripts created by PkgDev.generate().

@cecileane cecileane merged commit 0b06433 into JuliaPhylo:master Mar 29, 2018
@crsl4
Copy link
Member

crsl4 commented Mar 29, 2018

Sorry Cecile, not sure what you want me to do. We have enabled Codecov access to the PhyloNetworks repo. Actually, in my Codecov, there is a collaborators section that I had not seen:

Collaborators
Codecov uses GitHub permissions to authenticate users. No setup necessary.
Ask your team members to login to Codecov and they will have read/write access to the appropriate repositories.

We do not have Coveralls setup for PhyloNetworks, because I thought it was either Codecov or Coveralls (not both). I don't understand what specifics about the set-up would you like me to check. Please let me know!

@pbastide pbastide deleted the fix_NLopt branch April 3, 2018 06:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants