Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Rotations.jl to 1.0 #587

Merged
merged 7 commits into from
Jun 2, 2020
Merged

Update Rotations.jl to 1.0 #587

merged 7 commits into from
Jun 2, 2020

Conversation

rdeits
Copy link
Collaborator

@rdeits rdeits commented May 21, 2020

  • Quat -> UnitQuaternion
  • RodriguesVec -> RotationVec
  • SPQuat -> MRP (I'm not thrilled about that one. We can also introduce a type alias if you want).

Also add LightXML 0.9 compatibility (no changes as far as I can tell, except that it no longer needs BinaryProvider)

@rdeits
Copy link
Collaborator Author

rdeits commented May 21, 2020

Ah, ok, I think I'll need to regenerate the manifests on an older Julia version so they don't get the jll-specific dependencies. I also need to figure out why I'm getting an old version of MeshCatMechanisms--I think it might have a missing dependency upper bound on an old version.

@tkoolen
Copy link
Collaborator

tkoolen commented Jun 1, 2020

Thanks. I went ahead and added a ModifiedRodriguesParam type alias; I agree that MRP is just a bad name. Updated example notebook manifests again. I'm also going to drop support for Julia < 1.3. I don't have the bandwidth to deal with all the various possible configurations stemming from the jll change, and e.g. DifferentialEquations has dropped support for < 1.3 as well. We have solid releases that work for earlier versions.

@tkoolen tkoolen merged commit fdb9e5a into master Jun 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants