Skip to content

Commit

Permalink
Fix Azurite/Minio container naming (#34)
Browse files Browse the repository at this point in the history 
* Fix Azurite/Minio container naming

* Version bump
  • Loading branch information
@jfunstonRAI
jfunstonRAI authored Jan 18, 2024
1 parent 715e687 commit db6d637
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 3 deletions.
2 changes: 1 addition & 1 deletion Project.toml
View file
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
name = "CloudBase"
uuid = "85eb1798-d7c4-4918-bb13-c944d38e27ed"
authors = ["quinnj <quinn.jacobd@gmail.com>"]
version = "1.4.4"
version = "1.4.5"

[deps]
Base64 = "2a0f44e3-6c83-55bd-87e4-b1978d98bd5f"
Expand Down
4 changes: 2 additions & 2 deletions src/CloudTest.jl
View file
Original file line number Diff line number Diff line change
Expand Up @@ -179,7 +179,7 @@ function run(; dir=nothing, bucket=nothing, public=false, startupDelay=0.25, deb
return p, port
end
credentials = AWS.Credentials("minioadmin", "minioadmin")
bkt = AWS.Bucket(something(bucket, "jl-minio-$(abs(rand(Int16)))"); host="http://127.0.0.1:$port")
bkt = AWS.Bucket(something(bucket, "jl-minio-$(rand(UInt16))"); host="http://127.0.0.1:$port")
resp = AWS.put(bkt.baseurl, []; service="s3", credentials, status_exception=false)
while resp.status != 200
if resp.status == 503
Expand Down Expand Up @@ -296,7 +296,7 @@ function run(; dir=nothing, container=nothing, public=false, startupDelay=3, deb
end
acct = "devstoreaccount1"
protocol = use_ssl ? "https" : "http"
cont = Azure.Container(something(container, "jl-azurite-$(abs(rand(Int16)))"), acct; host="$protocol://127.0.0.1:$port")
cont = Azure.Container(something(container, "jl-azurite-$(rand(UInt16))"), acct; host="$protocol://127.0.0.1:$port")
key = "Eby8vdM02xNOcqFlqUwJPLlmEtlCDXJ1OUzFT50uSRZ6IFsuFq2UVErCz4I6tq/K1SZFPTOtr/KBHBeksoGMGw=="
credentials = Azure.Credentials(acct, key)
headers = public ? ["x-ms-blob-public-access" => "container"] : []
Expand Down

2 comments on commit db6d637

@nickrobinson251
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@JuliaRegistrator register

@JuliaRegistrator
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Registration pull request created: JuliaRegistries/General/99145

Tip: Release Notes

Did you know you can add release notes too? Just add markdown formatted text underneath the comment after the text
"Release notes:" and it will be added to the registry PR, and if TagBot is installed it will also be added to the
release that TagBot creates. i.e.

@JuliaRegistrator register

Release notes:

## Breaking changes

- blah

To add them here just re-invoke and the PR will be updated.

Tagging

After the above pull request is merged, it is recommended that a tag is created on this repository for the registered package version.

This will be done automatically if the Julia TagBot GitHub Action is installed, or can be done manually through the github interface, or via:

git tag -a v1.4.5 -m "<description of version>" db6d637b5c6ee4e36c0cfc398e7ad62a65696a69
git push origin v1.4.5

Please sign in to comment.