Fix Azurite/Minio container naming #34
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #34 +/- ##
=======================================
Coverage 67.21% 67.21%
=======================================
Files 5 5
Lines 610 610
=======================================
Hits 410 410
Misses 200 200 ☔ View full report in Codecov by Sentry. |
nickrobinson251
approved these changes
Jan 18, 2024
Thanks Nick! I pushed the version bump. |
|
Great catch; thanks @jfunstonRAI! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Azurite does not support double dashes in container names (a 400 bad request will be returned). This fixes a bug where a container name with double dashes could be generated if the random value is -32768, which overflows
absto still return -32768.