Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix deprecated Threads.nthreads() #204

Closed
wants to merge 1 commit into from
Closed

Fix deprecated Threads.nthreads() #204

wants to merge 1 commit into from

Conversation

IanButterworth
Copy link
Contributor

@IanButterworth IanButterworth commented Aug 3, 2022 •
edited
Loading

Threads.nthreads() is going to be deprecated in JuliaLang/julia#45447

This needs to be fixed before JuliaLang/julia#45447 merges because Base tests run with --depwarn=error https://github.com/JuliaLang/julia/blob/df846436bb91b291be988f5e18e256d514b97347/test/testenv.jl#L19

@IanButterworth IanButterworth mentioned this pull request Aug 3, 2022
Closed
@IanButterworth IanButterworth changed the title Fix deprecated Threads.threads() Fix deprecated Threads.nthreads() Aug 3, 2022
DilumAluthge
DilumAluthge previously approved these changes Aug 3, 2022
View reviewed changes
@IanButterworth
Copy link
Contributor Author

I think this needs signoff from @JeffBezanson / @vtjnash that Threads.maxthreadid() is the name that's going to be used, given JuliaLang/julia#45447 can't be merged first

vtjnash
vtjnash requested changes Aug 3, 2022
View reviewed changes
Copy link
Contributor

@vtjnash vtjnash left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FWIW, this would be very wrong, since there is no replacement for nthreads now

vtjnash
vtjnash requested changes Aug 3, 2022
View reviewed changes
Copy link
Contributor

@vtjnash vtjnash left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please remove all assumptions of thread-local-storage

@rayegun
Copy link
Member

rayegun commented Aug 3, 2022

That will require a pretty significant rewrite of the CHOLMOD wrapper. We'll have to carry workspaces and settings around with each Factor object now I believe.

@DilumAluthge
Copy link
Contributor

Could you use Base.task_local_storage?

@IanButterworth
Copy link
Contributor Author

I'll leave the necessary changes up to @Wimmerer

@IanButterworth IanButterworth deleted the ib/deprecate_nthreads branch August 3, 2022 19:56
@rayegun rayegun mentioned this pull request Aug 4, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vtjnash vtjnash vtjnash requested changes

@DilumAluthge DilumAluthge DilumAluthge left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@IanButterworth @rayegun @DilumAluthge @vtjnash