Remove Thread-local storage from CHOLMOD and SPQR #206
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@IanButterworth does this fix the issue? |
Codecov Report
@@ Coverage Diff @@
## main #206 +/- ##
==========================================
+ Coverage 92.06% 92.13% +0.06%
==========================================
Files 11 11
Lines 7161 7160 -1
==========================================
+ Hits 6593 6597 +4
+ Misses 568 563 -5
📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more |
vchuravy
reviewed
Aug 4, 2022
fredrikekre
reviewed
Aug 6, 2022
| end | ||
|
|
||
| function getcommon() | ||
| return get!(task_local_storage(), :cholmod_common, newcommon())::Ref{cholmod_common} |
There was a problem hiding this comment.
Should this not be
get!(newcommon, task_local_storage(), :cholmod_common)::Ref{cholmod_common}
? As it is now a new object is created for every call.
There was a problem hiding this comment.
The docs say it's collection, key, default right?
There was a problem hiding this comment.
There's another method where you can give a function/type as a first arg. Note that Fredrik's suggestion gives the type but doesn't evaluate it
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #204
This PR takes the path of least resistance and just uses
task_local_storage. The part that most needs review is the addition of a call tocholmod_l_finish. This is attached to thecholmod_commonobject which is lazily created in each task (which uses CHOLMOD).I think this is correct, but I'm not 100% certain on the lifetime of
task_local_storage.