[system-health] Remove monit dependency from system health #91
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -1,29 +1,181 @@ | |||
|
|
|||
There was a problem hiding this comment.
Add monit back to check file system and customized check
Junchao-Mellanox
force-pushed
the
system-health-enhance
branch
from
a5c7a57 to
4316f64
Compare
keboliu
approved these changes
Oct 21, 2021
Junchao-Mellanox
force-pushed
the
system-health-enhance
branch
from
4316f64 to
bb121fb
Compare
Junchao-Mellanox
force-pushed
the
system-health-enhance
branch
from
bb121fb to
5a8d671
Compare
Junchao-Mellanox
pushed a commit
that referenced
this pull request
Nov 25, 2021
e466ac226c48cf87f83aa5564efd7155ac97a0c1 (HEAD -> master, origin/master, origin/HEAD) Reject incorrect CIDR addresses while configuring routes (#91) 07cf59d866914ef7cb6901d51f289f0bee721e44 [CI] Set up Azure pipeline (#89) 47476acdfaf668ab0cd9ae2443205a3bdc2e9ef9 Upgrade Go version to 1.14 (#90) ee887c785c10d8b4f70db90ca50cc398327c5d73 Added flag to make go/pkg/ folder writable (removable) (#87) 6cfc8fe110c46a1ee5a8430e02a440b5a7b4006d (origin/shilongliu/azp) Default Vrf static route support (#85) d3e8b8e4aee278fa11d7d86acabdab3fffc70d5a Add BFD config to subinterface and neighbor (#68) 8d4fd4a56b637d3b7403c321aef36b8dff58cd62 Fix WS-2018-0594 potential non-random UUIDs security issue (#78) fad87fa20f6b15e28c90e02a131c44d236d6a751 Update API description for default vrf and ecmp routes (#82) Signed-off-by: Abhishek Dosi <abdosi@microsoft.com>
Junchao-Mellanox
pushed a commit
that referenced
this pull request
Feb 15, 2023
…telemetry (sonic-net#13112) Why I did it golang lib xmlquery v1.2.1 has critical security issue. MS Component Governance created an alert. Update submodule HEAD to fix CG alert about CVE-2020-25614 How I did it sonic-mgmt-framework a72d9ee Fix CG alert CVE-2020-25614 about xmlquery v1.2.1 (#91) sonic-telemetrey 727aefd Fix CG alert CVE-2020-25614 about xmlquery v1.2.1 (#107)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why I did it
Command
monit summary -Bcan no longer display the status for each critical process, system-health should not depend on it and need find a way to monitor the status of critical processes. The PR is to address that. monit is still used by system-health to do file system check as well as customize check.How I did it
How to verify it
Which release branch to backport (provide reason below if selected)
Description for the changelog
A picture of a cute animal (not mandatory but encouraged)