Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update README.md #81

Merged
merged 4 commits into from
Sep 24, 2021
Merged

Update README.md #81

merged 4 commits into from
Sep 24, 2021

Conversation

msands
Copy link
Contributor

@msands msands commented Sep 24, 2021

Previous link to David Gilbertson's article was a broken hackernoon link, as well as the same hackernoon link on David's profile page on hackernoon.

this PR just changes the link to a viable medium link, which is still written by David Gilbertson, so he retains all credit.

karlwilbur and others added 4 commits April 5, 2021 12:26
* develop:
  Bump version to `2.2.3`
  Fix regexp for numeric domains (fixes K-and-R#72)
  Add `EmailValidator::Error` class, raise `EmailValidator::Error` when invalid `mode`
  Add checks for double dash in domain
  Fix specs for numeric-only domains labels
  Add checks for numeric-only TLDs in tests
  Add tests to ensure that `regexp` returns expected value
  Bump y18n from 3.2.1 to 3.2.2
  Add failing test: strict mode should accept numbers only domains
  Update .travis.yml
Previous link to David Gilbertson's article was a broken hackernoon link, as well as the same hackernoon link on David's profile page on hackernoon.

this PR just changes the link to a viable medium link, which is still written by David Gilbertson, so he retains all credit.
@karlwilbur
Copy link
Member

Thank you, @msands.

@karlwilbur karlwilbur changed the base branch from master to develop September 24, 2021 13:34
@karlwilbur karlwilbur merged commit 32e27db into K-and-R:develop Sep 24, 2021
@msands msands deleted the patch-1 branch September 28, 2021 03:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants